Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(mtr):add double_float and func_sec_to_time(#497) #1135

Merged
merged 2 commits into from
Dec 17, 2022
Merged

test(mtr):add double_float and func_sec_to_time(#497) #1135

merged 2 commits into from
Dec 17, 2022

Conversation

shangyanwen
Copy link
Contributor

Summary about this PR

Issue Number: close #497

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented Dec 16, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-testing label Dec 16, 2022
@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Base: 42.73% // Head: 42.73% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (039fef8) compared to base (e4b7a5e).
Patch has no changes to coverable lines.

❗ Current head 039fef8 differs from pull request most recent head cbf94cc. Consider uploading reports for the commit cbf94cc to get more accurate results

Additional details and impacted files
@@               Coverage Diff                @@
##           stonedb-5.7-dev    #1135   +/-   ##
================================================
  Coverage            42.73%   42.73%           
================================================
  Files                 1830     1830           
  Lines               395962   395938   -24     
================================================
+ Hits                169214   169219    +5     
+ Misses              226748   226719   -29     
Impacted Files Coverage Δ
storage/innobase/include/ut0mutex.ic 71.42% <0.00%> (-23.81%) ⬇️
strings/str2int.c 72.72% <0.00%> (-6.07%) ⬇️
storage/innobase/mach/mach0data.cc 83.78% <0.00%> (-5.41%) ⬇️
storage/innobase/row/row0umod.cc 62.50% <0.00%> (-4.17%) ⬇️
sql/mdl.cc 66.11% <0.00%> (-3.33%) ⬇️
storage/innobase/sync/sync0arr.cc 53.38% <0.00%> (-0.85%) ⬇️
storage/innobase/srv/srv0srv.cc 83.05% <0.00%> (-0.56%) ⬇️
sql/mysqld.cc 68.12% <0.00%> (-0.53%) ⬇️
storage/innobase/rem/rem0rec.cc 68.59% <0.00%> (-0.51%) ⬇️
sql/sql_connect.cc 40.61% <0.00%> (-0.39%) ⬇️
... and 35 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

@lujiashun lujiashun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit f98ab95 into stoneatom:stonedb-5.7-dev Dec 17, 2022
@Nliver Nliver added this to the stonedb_5.7_v1.0.2 milestone Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

feature: Add the MTR test case for tianmu
4 participants