Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(mtr): add some mtr test cases(#497) #1195

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

davidshiz
Copy link
Collaborator

[summary]
add test cases about unsigned/escape/replace into/zerofill

Summary about this PR

Issue Number: ref #497

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented Jan 6, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-testing label Jan 6, 2023
@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Base: 43.30% // Head: 43.32% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (682944f) compared to base (74160c0).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           stonedb-5.7-dev    #1195      +/-   ##
===================================================
+ Coverage            43.30%   43.32%   +0.02%     
===================================================
  Files                 1830     1830              
  Lines               396111   396111              
===================================================
+ Hits                171535   171620      +85     
+ Misses              224576   224491      -85     
Impacted Files Coverage Δ
storage/tianmu/core/engine_convert.cpp 68.23% <100.00%> (ø)
storage/innobase/include/ut0mutex.ic 52.38% <0.00%> (-19.05%) ⬇️
strings/str2int.c 72.72% <0.00%> (-6.07%) ⬇️
sql/mdl.cc 66.11% <0.00%> (-3.33%) ⬇️
storage/innobase/buf/buf0buddy.cc 33.76% <0.00%> (-2.60%) ⬇️
storage/myisam/mi_search.c 38.65% <0.00%> (-1.69%) ⬇️
storage/myisam/mi_delete.c 25.52% <0.00%> (-1.21%) ⬇️
storage/innobase/rem/rem0rec.cc 68.08% <0.00%> (-1.02%) ⬇️
storage/innobase/btr/btr0bulk.cc 80.89% <0.00%> (-0.96%) ⬇️
sql/conn_handler/connection_handler_manager.cc 44.44% <0.00%> (-0.86%) ⬇️
... and 46 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@shangyanwen shangyanwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

[summary]
add mtr test cases about unsigned/escape/replace into/zerofill
Copy link

@lujiashun lujiashun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 67b5c20 into stoneatom:stonedb-5.7-dev Jan 9, 2023
@davidshiz davidshiz deleted the mtr branch January 9, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants