Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tianmu):the data is wrong when altering table after deleting.(#1199) #1272

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

DandreChen
Copy link
Collaborator

Because the records which was deleted is not filtered.

Summary about this PR

Issue Number: close #1199

[summary]
Because the records which was deleted is not filtered in fill_row().

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented Feb 3, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-bug bug for pull request label Feb 3, 2023
@DandreChen DandreChen marked this pull request as draft February 3, 2023 08:53
@Nliver Nliver added this to the stonedb_5.7_v1.0.3 milestone Feb 4, 2023
@DandreChen DandreChen force-pushed the alter_delete branch 4 times, most recently from 10e858b to a4caa11 Compare February 6, 2023 03:12
@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Base: 43.11% // Head: 43.12% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (f2f000e) compared to base (bdbf8d9).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@               Coverage Diff                @@
##           stonedb-5.7-dev    #1272   +/-   ##
================================================
  Coverage            43.11%   43.12%           
================================================
  Files                 1830     1830           
  Lines               396311   396320    +9     
================================================
+ Hits                170854   170897   +43     
+ Misses              225457   225423   -34     
Impacted Files Coverage Δ
storage/tianmu/core/dimension_group.cpp 80.37% <ø> (ø)
storage/tianmu/core/tianmu_table.h 90.90% <100.00%> (+0.43%) ⬆️
storage/tianmu/handler/ha_tianmu.cpp 56.44% <100.00%> (+0.33%) ⬆️
storage/innobase/row/row0vers.cc 71.66% <0.00%> (-4.00%) ⬇️
storage/innobase/sync/sync0arr.cc 51.69% <0.00%> (-1.70%) ⬇️
storage/innobase/page/page0page.cc 62.72% <0.00%> (-1.34%) ⬇️
storage/innobase/sync/sync0rw.cc 98.88% <0.00%> (-1.12%) ⬇️
storage/innobase/buf/buf0flu.cc 84.82% <0.00%> (-0.53%) ⬇️
strings/ctype-simple.c 60.86% <0.00%> (-0.51%) ⬇️
sql/sql_profile.cc 10.30% <0.00%> (-0.43%) ⬇️
... and 20 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@DandreChen DandreChen force-pushed the alter_delete branch 3 times, most recently from d661331 to 3857690 Compare February 14, 2023 02:50
@DandreChen DandreChen marked this pull request as ready for review February 14, 2023 03:06
@DandreChen DandreChen force-pushed the alter_delete branch 2 times, most recently from 828ccb5 to 3446379 Compare February 15, 2023 08:37
…neatom#1199)

Because the records which was deleted is not filtered in fill_row().
Copy link

@lujiashun lujiashun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit ef67d37 into stoneatom:stonedb-5.7-dev Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-bug bug for pull request
Projects
4 participants