Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tianmu):issue1090.test occasionally fails to run(#1234) #1314

Merged
merged 2 commits into from
Feb 16, 2023

Conversation

konghaiya
Copy link
Collaborator

@konghaiya konghaiya commented Feb 16, 2023

Cause of the problem:
There is a problem in the method of waiting for the master/slave synchronization to complete, which leads to the data not being synchronized, and then proceed to the next step

Modify scheme:
Use the correct method to determine whether the slave database is synchronized

Summary about this PR

Issue Number: close #1234

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@konghaiya konghaiya self-assigned this Feb 16, 2023
@konghaiya konghaiya added this to the stonedb_5.7_v1.0.4 milestone Feb 16, 2023
@mergify
Copy link
Contributor

mergify bot commented Feb 16, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

Cause of the problem:
There is a problem in the method of waiting for the master/slave synchronization to complete,
which leads to the data not being synchronized, and then proceed to the next step

Modify scheme:
Use the correct method to determine whether the slave database is synchronized
Copy link

@lujiashun lujiashun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, LGTM

@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Base: 43.34% // Head: 43.13% // Decreases project coverage by -0.21% ⚠️

Coverage data is based on head (fffad04) compared to base (ad4e0fa).
Patch coverage: 64.73% of modified lines in pull request are covered.

❗ Current head fffad04 differs from pull request most recent head b714ee6. Consider uploading reports for the commit b714ee6 to get more accurate results

Additional details and impacted files
@@                 Coverage Diff                 @@
##           stonedb-5.7-dev    #1314      +/-   ##
===================================================
- Coverage            43.34%   43.13%   -0.21%     
===================================================
  Files                 1830     1830              
  Lines               396171   396311     +140     
===================================================
- Hits                171706   170960     -746     
- Misses              224465   225351     +886     
Impacted Files Coverage Δ
sql/sql_derived.cc 95.89% <ø> (+1.36%) ⬆️
sql/sql_lex.h 53.06% <ø> (ø)
sql/sql_optimizer.h 74.54% <ø> (ø)
sql/sql_select.h 73.27% <ø> (ø)
sql/table.h 55.00% <ø> (ø)
storage/tianmu/core/aggregation_algorithm.h 60.00% <ø> (+22.50%) ⬆️
storage/tianmu/core/engine.cpp 56.87% <0.00%> (-0.36%) ⬇️
storage/tianmu/core/engine.h 30.43% <ø> (ø)
storage/tianmu/core/pack_guardian.h 100.00% <ø> (ø)
storage/tianmu/core/temp_table.cpp 71.71% <ø> (ø)
... and 113 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@RingsC RingsC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit b5e24a8 into stoneatom:stonedb-5.7-dev Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-bug bug for pull request
Projects
Development

Successfully merging this pull request may close these issues.

bug: Issue1090.test occasionally fails to run
4 participants