-
-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tianmu):issue1090.test occasionally fails to run(#1234) #1314
Conversation
Thanks for the contribution! Please review the labels and make any necessary changes. |
c966502
to
28d992b
Compare
Cause of the problem: There is a problem in the method of waiting for the master/slave synchronization to complete, which leads to the data not being synchronized, and then proceed to the next step Modify scheme: Use the correct method to determine whether the slave database is synchronized
28d992b
to
fffad04
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, LGTM
Codecov ReportBase: 43.34% // Head: 43.13% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## stonedb-5.7-dev #1314 +/- ##
===================================================
- Coverage 43.34% 43.13% -0.21%
===================================================
Files 1830 1830
Lines 396171 396311 +140
===================================================
- Hits 171706 170960 -746
- Misses 224465 225351 +886
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Cause of the problem:
There is a problem in the method of waiting for the master/slave synchronization to complete, which leads to the data not being synchronized, and then proceed to the next step
Modify scheme:
Use the correct method to determine whether the slave database is synchronized
Summary about this PR
Issue Number: close #1234
Tests Check List
Changelog
Documentation