Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tianmu): support unsigned load export issue1329 #1334

Merged
merged 7 commits into from
Mar 6, 2023
Merged

feat(tianmu): support unsigned load export issue1329 #1334

merged 7 commits into from
Mar 6, 2023

Conversation

hustjieke
Copy link
Collaborator

@hustjieke hustjieke commented Feb 28, 2023 •
edited
Loading

Summary about this PR

Issue Number: close #1329

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@hustjieke
feat(tianmu): support_unsigned_data [tinyint~int32] stoneatom#1267
f987812 
[summary]
1. expand unsigned boundary from signed boundary to max valued.
2. code cover create/insert(delayed/no delayed mode)/update/delete/select.
3. functions and operators(agg and math calculation)

refs: stoneatom#1266
related issue: stoneatom#1151
@hustjieke
fix(core): revert uint64_t fixmax to int64_t, fix file formate temp_t…
f7de1ab 
…able.cpp from dos2unix stoneatom#1267
@hustjieke
fix(tianmu): add unsigned test cases with sql_mode='' & remove magic …
1d45af4 
…numbers stoneatom#1267
@hustjieke
fix(tianmu): fix lint format check stoneatom#1267
b962350
@hustjieke
feat(tianmu): support load export unsigned [tinyint~int] stoneatom#1329
a1a0c0b 
[summary]
1. add support in load/export module
2. fix format with clint
@hustjieke hustjieke changed the title Feat support unsigned load export issue1329 feat(tianmu): support unsigned load export issue1329 Feb 28, 2023
@mergify mergify bot added the PR-feature feature for pull request label Feb 28, 2023
@hustjieke
Copy link
Collaborator Author

image

The old commits with new just merge into 5.7-dev branch directly. The branch `stonedb/feat_support_unsigned_data_types` will be deleted.

@hustjieke hustjieke requested review from RingsC and wisehead February 28, 2023 03:49
@hustjieke hustjieke force-pushed the feat_support_unsigned_load_export_issue1329 branch from c1d3d39 to ab66ecf Compare February 28, 2023 05:55
@mergify
Copy link
Contributor

mergify bot commented Feb 28, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@codecov
Copy link

codecov bot commented Feb 28, 2023 •
edited
Loading

Codecov Report

Patch coverage: 73.50% and project coverage change: +0.01 🎉

Comparison is base (4105e58) 43.12% compared to head (ab66ecf) 43.14%.

❗ Current head ab66ecf differs from pull request most recent head 7fc48b8. Consider uploading reports for the commit 7fc48b8 to get more accurate results

Additional details and impacted files 
@@                 Coverage Diff                 @@
##           stonedb-5.7-dev    #1334      +/-   ##
===================================================
+ Coverage            43.12%   43.14%   +0.01%     
===================================================
  Files                 1830     1830              
  Lines               396392   396441      +49     
===================================================
+ Hits                170955   171031      +76     
+ Misses              225437   225410      -27
Impacted Files Coverage Δ
storage/tianmu/core/data_type.h 63.63% <ø> (ø)
storage/tianmu/core/engine.cpp 54.56% <0.00%> (+0.30%) ⬆️
storage/tianmu/core/engine.h 30.43% <ø> (ø)
storage/tianmu/core/temp_table.cpp 71.71% <0.00%> (ø)
storage/tianmu/handler/ha_tianmu.cpp 55.85% <40.90%> (-0.19%) ⬇️
storage/tianmu/core/column_type.h 64.70% <50.00%> (ø)
storage/tianmu/core/tianmu_attr_typeinfo.h 78.12% <50.00%> (-1.88%) ⬇️
storage/tianmu/common/common_definitions.cpp 58.46% <52.00%> (+22.39%) ⬆️
storage/tianmu/core/engine_results.cpp 85.53% <90.90%> (+0.33%) ⬆️
storage/tianmu/core/column_type.cpp 96.66% <100.00%> (+0.11%) ⬆️
... and 58 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wisehead wisehead requested a review from duanfuxiang0 March 1, 2023 01:32
@hustjieke hustjieke marked this pull request as ready for review March 2, 2023 02:48
@hustjieke
Copy link
Collaborator Author

image

The old commits with new just merge into 5.7-dev branch directly. The branch stonedb/feat_support_unsigned_data_types will be deleted.

cc @RingsC @duanfuxiang0
{lease take a review, thks!

duanfuxiang0
duanfuxiang0 approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@duanfuxiang0 duanfuxiang0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 43fcede into stoneatom:stonedb-5.7-dev Mar 6, 2023
@Nliver Nliver added this to the StoneDB_5.7_v1.0.3 milestone Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duanfuxiang0 duanfuxiang0 duanfuxiang0 approved these changes

@wisehead wisehead wisehead approved these changes

@RingsC RingsC Awaiting requested review from RingsC

Assignees

@hustjieke hustjieke

Labels
PR-feature feature for pull request
Projects
StoneDB for MySQL 5.7
Status: Done
Milestone
StoneDB_5.7_v1.0.3
Development

Successfully merging this pull request may close these issues.

feat: impl loader, exporter for unsigned [tinyint~int]
4 participants
@hustjieke @wisehead @duanfuxiang0 @Nliver