Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tianm):oltp_read_write.lua sysbench returned error 1366(#1371) #1372

Merged
merged 2 commits into from
Mar 9, 2023

Conversation

konghaiya
Copy link
Collaborator

@konghaiya konghaiya commented Mar 9, 2023

Cause of the problem:
The reason for the problem is that when the update and update data are merged, there is a place where the update bitmap is not set, resulting in the subsequent data reading confusion

Summary about this PR

Issue Number: close #1371

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented Mar 9, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-bug bug for pull request label Mar 9, 2023
storage/tianmu/util/bitset.h Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03 ⚠️

Comparison is base (e8f0794) 43.13% compared to head (ec75c28) 43.10%.

❗ Current head ec75c28 differs from pull request most recent head 5f31780. Consider uploading reports for the commit 5f31780 to get more accurate results

Additional details and impacted files
@@                 Coverage Diff                 @@
##           stonedb-5.7-dev    #1372      +/-   ##
===================================================
- Coverage            43.13%   43.10%   -0.03%     
===================================================
  Files                 1836     1836              
  Lines               397196   397198       +2     
===================================================
- Hits                171314   171196     -118     
- Misses              225882   226002     +120     
Impacted Files Coverage Δ
storage/tianmu/util/bitset.h 0.00% <0.00%> (ø)
storage/innobase/include/ut0mutex.ic 52.38% <0.00%> (-42.86%) ⬇️
storage/innobase/mach/mach0data.cc 83.78% <0.00%> (-5.41%) ⬇️
sql/mdl.cc 66.11% <0.00%> (-3.20%) ⬇️
storage/tianmu/core/engine.cpp 48.59% <0.00%> (-2.43%) ⬇️
storage/innobase/mtr/mtr0mtr.cc 71.02% <0.00%> (-2.34%) ⬇️
storage/innobase/trx/trx0undo.cc 69.26% <0.00%> (-2.05%) ⬇️
storage/innobase/include/ib0mutex.h 71.45% <0.00%> (-0.94%) ⬇️
storage/innobase/sync/sync0arr.cc 53.38% <0.00%> (-0.85%) ⬇️
sql/mysqld.cc 68.13% <0.00%> (-0.53%) ⬇️
... and 22 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

…#1371)

Cause of the problem:
The bit bitmap was not initialized when it was created, resulting in the subsequent data confusion
Copy link
Contributor

@RingsC RingsC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@duanfuxiang0 duanfuxiang0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit bda6751 into stoneatom:stonedb-5.7-dev Mar 9, 2023
@konghaiya konghaiya deleted the dev_lhj_1371 branch March 27, 2023 06:42
@Nliver Nliver added this to the StoneDB_5.7_v1.0.3 milestone Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-bug bug for pull request
Projects
Development

Successfully merging this pull request may close these issues.

bug: oltp_read_write.lua sysbench returned error 1366 (Incorrect string value..)
4 participants