Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tianmu): fix mysqld crash when query where JOIN::propagate_dependencies… (#1628) #1639

Merged
merged 2 commits into from
Apr 28, 2023
Merged

Conversation

adofsauron
Copy link
Collaborator

@adofsauron adofsauron commented Apr 27, 2023

Summary about this PR

Issue Number: close #issue_number_you_created

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented Apr 27, 2023

This pull request's title should follow requirements next. @adofsauron please check it 👇.

Valid format:

fix(vc): fix sth..... (#3306)
  ^         ^---------^  ^----^
  |         |            |
  |         +            +-> you issue id.
  |         |
  |         +-> Summary in present tense.
  |
  +-------> Type: feat, fix, docs, workflow, style, refactor, test, website, chore

Valid types:

  • feat: new feature for stonedb
  • fix: bug fix for stonedb
  • docs: changes to the documentation
  • workflow: ci/cd in .github
  • perf: Changes to improve code performance
  • refactor: refactoring production code, eg. renaming a variable
  • style: formatting, missing semi colons, etc; no production code change
  • test: adding missing tests, refactoring tests; no production code change
  • website
  • chore: updating grunt tasks etc; no production code change

@mergify
Copy link
Contributor

mergify bot commented Apr 27, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

❗ No coverage uploaded for pull request base (stonedb-5.7-dev@70f15f1). Click here to learn what that means.
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head f3f6648 differs from pull request most recent head dd62120. Consider uploading reports for the commit dd62120 to get more accurate results

Additional details and impacted files
@@                Coverage Diff                 @@
##             stonedb-5.7-dev    #1639   +/-   ##
==================================================
  Coverage                   ?   55.21%           
==================================================
  Files                      ?     2031           
  Lines                      ?   431437           
  Branches                   ?        0           
==================================================
  Hits                       ?   238204           
  Misses                     ?   193233           
  Partials                   ?        0           
Impacted Files Coverage Δ
storage/tianmu/core/query_compile.cpp 69.50% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@konghaiya konghaiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 587d276 into stoneatom:stonedb-5.7-dev Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants