Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tianmu): backport support union different datetime type #1743 #1811

Merged
merged 1 commit into from
May 24, 2023
Merged

fix(tianmu): backport support union different datetime type #1743 #1811

merged 1 commit into from
May 24, 2023

Conversation

Double0101
Copy link
Collaborator

Summary about this PR

Issue Number: close #1743

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@Double0101
fix(tianmu): backport support union different datetime type stoneatom…
8518c3f 
…#1743

Cause:
  the function SecondColumn only return true when vc->type is Date.
Solution:
  use function ATI::IsDateTimeType(type), when vc->type is one of
DateTimeType return true.

this commit alse add some mtr in issue#1690
@mergify mergify bot added the PR-bug bug for pull request label May 22, 2023
hustjieke
hustjieke approved these changes May 24, 2023
View reviewed changes
Copy link
Collaborator

@hustjieke hustjieke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hustjieke hustjieke merged commit 58f36b1 into stoneatom:stonedb-8.0-dev May 24, 2023
@Double0101 Double0101 deleted the datetime-union branch May 25, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hustjieke hustjieke hustjieke approved these changes

Assignees
No one assigned
Labels
PR-bug bug for pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Double0101 @hustjieke