Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tianmu): backport ALTER table xxx ADD numeric column return error(#1734) #1832

Closed

Conversation

chenshengjiang
Copy link
Collaborator

@chenshengjiang chenshengjiang commented May 26, 2023

Summary about this PR

Issue Number: close #1734

1.Add test case: when alter table xxx add colmn operation is failed firstly, executing
alter table xxx add column by successful case again
2. Delete the temporary directory to solve the copy problem

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented May 26, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-bug bug for pull request label May 26, 2023
@chenshengjiang chenshengjiang changed the title fix(tianmu): backport ALTER table xxx ADD numeric column return error… fix(tianmu): backport ALTER table xxx ADD numeric column return error(#1734) May 26, 2023
@chenshengjiang chenshengjiang self-assigned this May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-bug bug for pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant