Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(mtr): add more test cases for tianmu(#1196) #1888

Merged
merged 2 commits into from
Jun 16, 2023

Conversation

davidshiz
Copy link
Collaborator

[summary]
case_when.test
drop_restric.test
empty_string_not_null.test
left_right_func.test
like_not_like.test
multi_join.test
order_by.test
ssb_small.test
union_case.test

Summary about this PR

Issue Number: ref #1196

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

[summary]
case_when.test
drop_restric.test
empty_string_not_null.test
left_right_func.test
like_not_like.test
multi_join.test
order_by.test
ssb_small.test
union_case.test
@mergify
Copy link
Contributor

mergify bot commented Jun 15, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-testing label Jun 15, 2023
@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.95 ⚠️

Comparison is base (798ca7a) 55.15% compared to head (badb133) 54.21%.

❗ Current head badb133 differs from pull request most recent head 80a3ca4. Consider uploading reports for the commit 80a3ca4 to get more accurate results

Additional details and impacted files
@@                 Coverage Diff                 @@
##           stonedb-5.7-dev    #1888      +/-   ##
===================================================
- Coverage            55.15%   54.21%   -0.95%     
===================================================
  Files                 2031     2031              
  Lines               431521   431521              
===================================================
- Hits                238018   233948    -4070     
- Misses              193503   197573    +4070     

see 241 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@davidshiz davidshiz requested a review from Nliver June 16, 2023 06:55
Copy link
Collaborator

@Nliver Nliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 288262f into stoneatom:stonedb-5.7-dev Jun 16, 2023
@davidshiz davidshiz deleted the mtr57 branch June 16, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants