fix(tianmu): add the TIME_to_ulonglong_time_round logic, and fix up precision loss problem and value overflow problem (#1173) #1894
+75
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…recision loss problem and value overflow problem (stoneatom#1173) When converting TIME or DATETIME to ulonglong numeric, the tianmu engine has not the TIME_to_ulonglong_time_round logic.Which causes the results different from innodb.Furthermore, i found another bug during processing the issue.When we close the tianmu_insert_delayed parameter, the TIME or DATETIME or TIMESTAMP type's data will loss precision when executing insert sql. PR Close stoneatom#1173
Xinqiangxu
changed the title
|
Thanks for the contribution! Please review the labels and make any necessary changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary about this PR
Issue Number: close #1173
Tests Check List
Changelog
Documentation