Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tianmu): The current version does not enable multithreaded aggregation optimization (#567) #573

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

adofsauron
Copy link
Collaborator

@adofsauron adofsauron commented Sep 26, 2022

The current version does not enable multithreaded aggregation optimization,
Here's why:
Currently, for multi-thread parallel,
it is not completely carried out to the physical layer,
for DPN and PACK data structure,
because the underlying physical block processing for multi-thread from the data structure support is missing,
when a multi-thread switch occurs,
the data that has been read out is reset.
More time is needed to support parallel read IO across multiple threads from the underlying data structures,
which is not available in the current version,
so we plan to start the second phase of the multi-thread read IO process completely.

Summary about this PR

Issue Number: close #567

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Improvement
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

    The current version does not enable multithreaded aggregation optimization,
    Here's why:
    Currently, for multi-thread parallel,
    it is not completely carried out to the physical layer,
    for DPN and PACK data structure,
    because the underlying physical block processing for multi-thread from the data structure support is missing,
    when a multi-thread switch occurs,
    the data that has been read out is reset.
    More time is needed to support parallel read IO across multiple threads from the underlying data structures,
    which is not available in the current version,
    so we plan to start the second phase of the multi-thread read IO process completely.
@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2022

This pull request's title should follow requirements next. @adofsauron please check it 👇.

Valid format:

fix(vc): fix sth..... (#3306)
  ^         ^---------^  ^----^
  |         |            |
  |         +            +-> you issue id.
  |         |
  |         +-> Summary in present tense.
  |
  +-------> Type: feat, fix, docs, workflow, style, refactor, test, website, chore

Valid types:

  • feat: new feature for stonedb
  • fix: bug fix for stonedb
  • docs: changes to the documentation
  • workflow: ci/cd in .github
  • refactor: refactoring production code, eg. renaming a variable
  • style: formatting, missing semi colons, etc; no production code change
  • test: adding missing tests, refactoring tests; no production code change
  • website
  • chore: updating grunt tasks etc; no production code change

@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@adofsauron adofsauron added this to the stonedb_5.7_v1.0.1 milestone Sep 26, 2022
@adofsauron adofsauron self-assigned this Sep 26, 2022
Copy link
Contributor

@RingsC RingsC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RingsC RingsC requested a review from konghaiya September 27, 2022 01:49
Copy link
Collaborator

@konghaiya konghaiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 0a176af into stoneatom:stonedb-5.7-dev Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: 2022-09-26 The associated query of multiple tables of the Tianmu engine is slow
3 participants