Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(StoneDB 8.0): Fix up the compiling extra-semi warnings. (#547) #592

Merged
merged 2 commits into from
Sep 27, 2022

Conversation

lujiashun
Copy link

Summary about this PR

Issue Number: ref #547
Fix up the compiling extra-semi warnings like this:
warning: extra ‘;’ after in-class function definition [-Wextra-semi]

step1:
make -j32 &> tianmu_build.log
step2:
grep "\-Wextra-semi"  tianmu_build.log| \
grep "function definition" | \
sort| \
uniq| \
awk -F ":"  '{printf("sed -i \"%ss#\\\;[ \\t]*\$##g\"  %s\n",$2,$1)}'  > fix-extra-semi.sh
step3:
sh fix-extra-semi.sh

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Improvement
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-feature feature for pull request label Sep 27, 2022
@lujiashun lujiashun self-assigned this Sep 27, 2022
@lujiashun lujiashun added this to the stonedb_8.0_v1.0.0 milestone Sep 27, 2022
Copy link
Contributor

@RingsC RingsC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, LGTM

Copy link
Collaborator

@DandreChen DandreChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 4769e0f into stoneatom:stonedb-8.0-dev Sep 27, 2022
@lujiashun lujiashun deleted the feat-547-extra-semi branch September 29, 2022 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-feature feature for pull request
Projects
Development

Successfully merging this pull request may close these issues.

3 participants