Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tianmu) Query results more data (#282) #599

Merged
merged 2 commits into from
Oct 17, 2022

Conversation

konghaiya
Copy link
Collaborator

@konghaiya konghaiya commented Sep 28, 2022

Cause:
Execution plan error when AND/OR sql logical operator in condition occurs at the same time.
Resolvent:
Optimize multiple equal execution plan logic.

Summary about this PR

Issue Number: close #282

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Improvement
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented Sep 28, 2022

This pull request's title should follow requirements next. @konghaiya please check it 👇.

Valid format:

fix(vc): fix sth..... (#3306)
  ^         ^---------^  ^----^
  |         |            |
  |         +            +-> you issue id.
  |         |
  |         +-> Summary in present tense.
  |
  +-------> Type: feat, fix, docs, workflow, style, refactor, test, website, chore

Valid types:

  • feat: new feature for stonedb
  • fix: bug fix for stonedb
  • docs: changes to the documentation
  • workflow: ci/cd in .github
  • refactor: refactoring production code, eg. renaming a variable
  • style: formatting, missing semi colons, etc; no production code change
  • test: adding missing tests, refactoring tests; no production code change
  • website
  • chore: updating grunt tasks etc; no production code change

@mergify
Copy link
Contributor

mergify bot commented Sep 28, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

Copy link
Collaborator

@isredstar isredstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@konghaiya konghaiya force-pushed the dev_lhj_282 branch 8 times, most recently from 2950596 to bd5afac Compare October 17, 2022 11:48
Copy link
Contributor

@RingsC RingsC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 9e4f2af into stoneatom:stonedb-5.7-dev Oct 17, 2022
@konghaiya konghaiya deleted the dev_lhj_282 branch October 17, 2022 12:30
konghaiya and others added 2 commits October 18, 2022 03:48
Cause:
Execution plan error when AND/OR sql logical operator in condition occurs at the same time
Resolvent:
Optimize multiple equal execution plan logic
@Nliver Nliver added this to the StoneDB_5.7_v1.0.1 milestone Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

bug: incorrect result set.Query results more data, see the bug text
4 participants