Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(StoneDB 8.0): format tianmu engine's code according to clang-format file. (#618) #619

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

lujiashun
Copy link

@lujiashun lujiashun commented Sep 29, 2022

Summary about this PR

Issue Number: close #618

The total source file number is 509, the number of file actually need to be formatted is 140;

root@ub01:/data/codebase/stonedb80/stonedb/storage/tianmu# find . -name *.h |wc
    313     313    7351
root@ub01:/data/codebase/stonedb80/stonedb/storage/tianmu# find . -name *.cpp |wc
    192     192    4839
root@ub01:/data/codebase/stonedb80/stonedb/storage/tianmu# find . -name *.hpp |wc
      0       0       0
root@ub01:/data/codebase/stonedb80/stonedb/storage/tianmu# find . -name *.cc |wc
      1       1      22

in storage\tianmu directory, execute the three command as below:

find . -name *.h  |xargs -i -n 1 clang-format --style=file -i {}
find . -name *.cpp  |xargs -i -n 1 clang-format --style=file -i {}
find . -name *.cc  |xargs -i -n 1 clang-format --style=file -i {}

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Improvement
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

…mat file. (stoneatom#618)

[summary]
1 using command "clang-format --style=file file_name";
@lujiashun lujiashun added the C-stonedb-8.0 associated with stonedb 8.0 label Sep 29, 2022
@lujiashun lujiashun self-assigned this Sep 29, 2022
@mergify
Copy link
Contributor

mergify bot commented Sep 29, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-feature feature for pull request label Sep 29, 2022
@hustjieke hustjieke removed the C-stonedb-8.0 associated with stonedb 8.0 label Sep 29, 2022
Copy link
Collaborator

@DandreChen DandreChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RingsC RingsC merged commit 8abd533 into stoneatom:stonedb-8.0-dev Sep 29, 2022
@lujiashun lujiashun deleted the feat-618 branch September 29, 2022 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-feature feature for pull request
Projects
Development

Successfully merging this pull request may close these issues.

feature(StoneDB 8.0): format tianmu engine's code according to clang-format file
4 participants