Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tianmu): Fix errors in the Q2/Q16/Q17/Q18/Q20/Q22 query result (#330, #331) #643

Closed
wants to merge 10 commits into from
Closed

fix(tianmu): Fix errors in the Q2/Q16/Q17/Q18/Q20/Q22 query result (#330, #331) #643

wants to merge 10 commits into from

Conversation

adofsauron
Copy link
Collaborator

@adofsauron adofsauron commented Oct 8, 2022 •
edited
Loading 

There are two reasons for this:
    1. The current parallel Hash join is not perfect for handling the exists subquery
    2. The shallow copy of ParameterizedFilter is not properly processed in the temporary table

the same as #620

Summary about this PR

Issue Number: close #330 #331

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Improvement
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@adofsauron
Resolved errors in query results Q14 and Q16
493448c 
    There are two reasons for this:
        1. The current parallel Hash join is not perfect for handling the EXISTS subquery
        2. The shallow copy of ParameterizedFilter is not properly processed in the temporary table
@adofsauron
Copy link
Collaborator Author

the same as #620

@mergify
Copy link
Contributor

mergify bot commented Oct 8, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-bug bug for pull request label Oct 8, 2022
@adofsauron adofsauron changed the title fix(tianmu): Fix errors in the Q4 (exists subquery) and Q16 query result (#330, #331) fix(tianmu): Fix errors in the Q2/Q16/Q17/Q18 query result (#330, #331) Oct 8, 2022
@adofsauron adofsauron changed the title fix(tianmu): Fix errors in the Q2/Q16/Q17/Q18 query result (#330, #331) fix(tianmu): Fix errors in the Q2/Q16/Q17/Q18/Q20/Q22 query result (#330, #331) Oct 10, 2022
@adofsauron adofsauron closed this by deleting the head repository Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR-bug bug for pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: slow-SQL-Q4-when subquery use exists sql on 10GB data spend 40 mininus and happen OOM on 100GB data
1 participant
@adofsauron