Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(StoneDB 8.0): adapt the Tianmu engine query interface to MySQL8.0 (#681) #683

Merged
merged 1 commit into from
Oct 11, 2022
Merged

feat(StoneDB 8.0): adapt the Tianmu engine query interface to MySQL8.0 (#681) #683

merged 1 commit into from
Oct 11, 2022

Conversation

DandreChen
Copy link
Collaborator

adapt the Tianmu engine query interface to MySQL8.0

Summary about this PR

Issue Number: close #681

[summary]
adapt Tianmu engine query interface for CTAS operation
adapt Tianmu engine query interface for query operation
add Query_expression::is_prepared() to to determine whether prepare for unit
change the List to mem_root_deque<Item *> in Query::Compile function
change the List to mem_root_deque<Item *> in Query::AddFields function

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Improvement
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@DandreChen DandreChen self-assigned this Oct 10, 2022
@DandreChen DandreChen added the C-stonedb-8.0 associated with stonedb 8.0 label Oct 10, 2022
@mergify
Copy link
Contributor

mergify bot commented Oct 10, 2022

This pull request's title should follow requirements next. @DandreChen please check it 👇.

Valid format:

fix(vc): fix sth..... (#3306)
  ^         ^---------^  ^----^
  |         |            |
  |         +            +-> you issue id.
  |         |
  |         +-> Summary in present tense.
  |
  +-------> Type: feat, fix, docs, workflow, style, refactor, test, website, chore

Valid types:

  • feat: new feature for stonedb
  • fix: bug fix for stonedb
  • docs: changes to the documentation
  • workflow: ci/cd in .github
  • refactor: refactoring production code, eg. renaming a variable
  • style: formatting, missing semi colons, etc; no production code change
  • test: adding missing tests, refactoring tests; no production code change
  • website
  • chore: updating grunt tasks etc; no production code change

@mergify
Copy link
Contributor

mergify bot commented Oct 10, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@DandreChen DandreChen modified the milestone: StoneDB v2.0 Oct 10, 2022
@DandreChen DandreChen changed the title feature(StoneDB 8.0): adapt the Tianmu engine query interface to MySQL8.0 (#681) feat(StoneDB 8.0): adapt the Tianmu engine query interface to MySQL8.0 (#681) Oct 10, 2022
@mergify mergify bot added the PR-feature feature for pull request label Oct 10, 2022
@DandreChen DandreChen force-pushed the stonedb-8.0-dev branch 2 times, most recently from 9c24f85 to 38403de Compare October 10, 2022 13:39
@DandreChen DandreChen requested a review from isredstar October 10, 2022 13:45
@DandreChen DandreChen added this to the stonedb_8.0_v1.0.0 milestone Oct 10, 2022
@DandreChen DandreChen marked this pull request as draft October 11, 2022 02:56
@DandreChen DandreChen force-pushed the stonedb-8.0-dev branch 3 times, most recently from 22e56d2 to 71ee366 Compare October 11, 2022 09:17
@DandreChen
feature(StoneDB 8.0): adapt the Tianmu engine query interface to MySQ…
e9e1ad0 
…L8.0 (stoneatom#681)

adapt Tianmu engine query interface for CTAS operation
adapt Tianmu engine query interface for query operation
add Query_expression::is_prepared() to to determine whether prepare for unit
change the List<Item> to mem_root_deque<Item *> in Query::Compile function
change the List<Item> to mem_root_deque<Item *> in Query::AddFields function
@DandreChen DandreChen marked this pull request as ready for review October 11, 2022 09:42
lujiashun
lujiashun approved these changes Oct 11, 2022
View reviewed changes
Copy link

@lujiashun lujiashun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 634751a into stoneatom:stonedb-8.0-dev Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lujiashun lujiashun lujiashun approved these changes

@RingsC RingsC RingsC approved these changes

@hustjieke hustjieke Awaiting requested review from hustjieke

@isredstar isredstar Awaiting requested review from isredstar

Assignees

@DandreChen DandreChen

Labels
C-stonedb-8.0 associated with stonedb 8.0 PR-feature feature for pull request
Projects
StoneDB for MySQL 8.0
Status: Done
Milestone
StoneDB_8.0_v1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@DandreChen @RingsC @lujiashun