Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(.*): improve code readability #11 #758

Merged
merged 2 commits into from
Oct 20, 2022
Merged

feat(.*): improve code readability #11 #758

merged 2 commits into from
Oct 20, 2022

Conversation

hustjieke
Copy link
Collaborator

@hustjieke hustjieke commented Oct 19, 2022 •
edited
Loading

Summary about this PR

[summary]

  1. NULL-->nullptr
  2. namespace "DBHandler"-->"handler"
  3. class TianmuHandler-->ha_tianmu
  4. sdb-->tianmu
  5. functions in ha_my_tianmu.cpp all renamed with prefix "ha_my_tianmu_xxx"

Issue Number: close #issue_number_you_created

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Improvement
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented Oct 19, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-feature feature for pull request label Oct 19, 2022
@hustjieke hustjieke changed the title feat(.*): improve code readable #11 feat(.*): improve code readability #11 Oct 20, 2022
@hustjieke hustjieke marked this pull request as ready for review October 20, 2022 08:00
DandreChen
DandreChen approved these changes Oct 20, 2022
View reviewed changes
Copy link
Collaborator

@DandreChen DandreChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lujiashun
lujiashun approved these changes Oct 20, 2022
View reviewed changes
Copy link

@lujiashun lujiashun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify
Copy link
Contributor

mergify bot commented Oct 20, 2022

This pull request has merge conflicts, you should resolve it before merged. @hustjieke please update it :)

Try @mergify update or update manually.

@hustjieke
feat(.*): improve code readable stoneatom#11
76393a2 
[summary]
1. NULL-->nullptr
2. namespace "DBHandler"-->"handler"
3. class TianmuHandler-->ha_tianmu
4. sdb-->tianmu
5. functions in ha_my_tianmu.cpp all renamed with prefix "ha_my_tianmu_xxx"
@hustjieke
feat(format): format code with clang-format-10
764d5be
@mergify mergify bot merged commit aebaceb into stoneatom:stonedb-8.0-dev Oct 20, 2022
@Nliver Nliver added this to the StoneDB_8.0_v1.0.0 milestone Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lujiashun lujiashun lujiashun approved these changes

@DandreChen DandreChen DandreChen approved these changes

@RingsC RingsC Awaiting requested review from RingsC

Assignees

@hustjieke hustjieke

Labels
PR-feature feature for pull request
Projects
StoneDB for MySQL 8.0
Status: Done
Milestone
StoneDB_8.0_v1.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@hustjieke @DandreChen @lujiashun @Nliver