Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tianmu): Supports user-defined functions (#538) #835

Closed
wants to merge 1 commit into from
Closed

feat(tianmu): Supports user-defined functions (#538) #835

wants to merge 1 commit into from

Conversation

adofsauron
Copy link
Collaborator

@adofsauron adofsauron commented Oct 27, 2022 •
edited by RingsC
Loading 

Requirement analysis:
https://adofsauron.blog.csdn.net/article/details/126991367

Changes description:
https://blog.csdn.net/adofsauron/article/details/127543458

Summary about this PR

Issue Number: close #538

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Improvement
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented Oct 27, 2022

This pull request's title should follow requirements next. @adofsauron please check it 👇.

Valid format:

fix(vc): fix sth..... (#3306)
  ^         ^---------^  ^----^
  |         |            |
  |         +            +-> you issue id.
  |         |
  |         +-> Summary in present tense.
  |
  +-------> Type: feat, fix, docs, workflow, style, refactor, test, website, chore

Valid types:

  • feat: new feature for stonedb
  • fix: bug fix for stonedb
  • docs: changes to the documentation
  • workflow: ci/cd in .github
  • refactor: refactoring production code, eg. renaming a variable
  • style: formatting, missing semi colons, etc; no production code change
  • test: adding missing tests, refactoring tests; no production code change
  • website
  • chore: updating grunt tasks etc; no production code change

@mergify
Copy link
Contributor

mergify bot commented Oct 27, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@adofsauron adofsauron changed the title fix(tianmu): Supports user-defined functions (#538) feat(tianmu): Supports user-defined functions (#538) Oct 28, 2022
RingsC
RingsC suggested changes Oct 28, 2022
View reviewed changes
mysql-test/suite/tianmu/r/custom_function.result Outdated
@@ -0,0 +1,9 @@
use test;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using "--source have_tianmu.inc"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using --disable_query_log/ --enable_query_log to shut down the unused log.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the file name should be attached to an issue.

@adofsauron adofsauron linked an issue Oct 31, 2022 that may be closed by this pull request
bug: ERROR 1436 (HY000): Thread stack overflow #851
Closed
3 tasks
RingsC
RingsC suggested changes Nov 1, 2022
View reviewed changes
mysql-test/suite/tianmu/t/issue538.test Outdated
`department_id` int(11) DEFAULT NULL
) ENGINE=TIANMU DEFAULT CHARSET=utf8mb4;

--disable_warnings
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do u use disable warnings twice?

mysql-test/suite/tianmu/t/issue538.test Outdated
a.employee_id = b.employee_id
and b.employee_name = 'David Tian';

SELECT get_value(1);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need these test. Taking an instance:
select sum (xx + get_value(1)) xxx
or
select xxx from xxx where xxx oper get_value.
....
etc.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, wait a time for add this

@adofsauron adofsauron closed this by deleting the head repository Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RingsC RingsC RingsC requested changes

@lujiashun lujiashun Awaiting requested review from lujiashun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: ERROR 1436 (HY000): Thread stack overflow feature: The Tianmu engine supports user defined function
2 participants
@adofsauron @RingsC