Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tianmu): group_concat.test has in-consistent behavior in CICD and prompt mode (#834) #843

Merged
merged 2 commits into from
Oct 29, 2022
Merged

fix(tianmu): group_concat.test has in-consistent behavior in CICD and prompt mode (#834) #843

merged 2 commits into from
Oct 29, 2022

Conversation

RingsC
Copy link
Contributor

@RingsC RingsC commented Oct 29, 2022

Summary about this PR

To enable group concat function for support text type, and enable some MTR test for this function.
Issue Number: close #834

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Improvement
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented Oct 29, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-bug bug for pull request label Oct 29, 2022
@RingsC
fix(tianmu): group_concat.test has in-consistent behavior in CICD and…
6ed2258 
… prompt mode (#834)

To enable  group concat function for support `text` type, and enable some MTR test for
this function.
@RingsC RingsC marked this pull request as ready for review October 29, 2022 11:24
DandreChen
DandreChen approved these changes Oct 29, 2022
View reviewed changes
Copy link
Collaborator

@DandreChen DandreChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lujiashun
lujiashun approved these changes Oct 29, 2022
View reviewed changes
Copy link

@lujiashun lujiashun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 2dba74e into stoneatom:stonedb-8.0-dev Oct 29, 2022
@RingsC RingsC deleted the stonedb-8.0-dev-groupby_concat branch October 29, 2022 12:13
@Nliver Nliver added this to the StoneDB_8.0_v1.0.0 milestone Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lujiashun lujiashun lujiashun approved these changes

@DandreChen DandreChen DandreChen approved these changes

@hustjieke hustjieke Awaiting requested review from hustjieke

Assignees

@RingsC RingsC

Labels
PR-bug bug for pull request
Projects
StoneDB for MySQL 8.0
Status: Done
Milestone
StoneDB_8.0_v1.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@RingsC @DandreChen @lujiashun @Nliver