Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tianmu): Improve the readbility of stonedb. (#11) #875

Merged
merged 1 commit into from
Nov 2, 2022
Merged

feat(tianmu): Improve the readbility of stonedb. (#11) #875

merged 1 commit into from
Nov 2, 2022

Conversation

konghaiya
Copy link
Collaborator

@konghaiya konghaiya commented Nov 2, 2022 •
edited
Loading

[summary]
1 class member variable refactor：exproter directory;
2 class member variable refactor：loader directory;

Summary about this PR

Issue Number: close #issue_number_you_created

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Improvement
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented Nov 2, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-feature feature for pull request label Nov 2, 2022
@konghaiya
Copy link
Collaborator Author

CR, PTAL, @RingsC @hustjieke @isredstar @duanfuxiang0

hustjieke
hustjieke approved these changes Nov 2, 2022
View reviewed changes
Copy link
Collaborator

@hustjieke hustjieke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

RingsC
RingsC suggested changes Nov 2, 2022
View reviewed changes
storage/tianmu/loader/load_parser.cpp Outdated Show resolved Hide resolved
storage/tianmu/loader/load_parser.h Outdated Show resolved Hide resolved
storage/tianmu/loader/parsing_strategy.h Show resolved Hide resolved
RingsC
RingsC approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@RingsC RingsC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 8050671 into stoneatom:stonedb-5.7-dev Nov 2, 2022
@konghaiya
feat(tianmu): Improve the readbility of stonedb. (stoneatom#11)
df8c156 
[summary]
1 class member variable refactor：exproter directory;
2 class member variable refactor：loader directory;
@konghaiya konghaiya deleted the dev_lhj_1102 branch November 22, 2022 01:35
@Nliver Nliver added this to the StoneDB_5.7_v1.0.2 milestone Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hustjieke hustjieke hustjieke approved these changes

@RingsC RingsC RingsC approved these changes

Assignees

@konghaiya konghaiya

Labels
PR-feature feature for pull request
Projects
StoneDB for MySQL 5.7
Status: Done
Milestone
StoneDB_5.7_v1.0.2
Development

Successfully merging this pull request may close these issues.
4 participants
@konghaiya @RingsC @hustjieke @Nliver