Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tianmu): support alter table xxx modify xxx type NULL/NOT NULL(#860) #878

Merged
merged 1 commit into from
Nov 4, 2022
Merged

feat(tianmu): support alter table xxx modify xxx type NULL/NOT NULL(#860) #878

merged 1 commit into from
Nov 4, 2022

Conversation

DandreChen
Copy link
Collaborator

Summary about this PR

Issue Number: close #860

[summary]
support field properties from NULL to NOT NULL
support field properties from NOT NULL to NULL

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Improvement
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented Nov 2, 2022

This pull request's title should follow requirements next. @DandreChen please check it 👇.

Valid format:

fix(vc): fix sth..... (#3306)
  ^         ^---------^  ^----^
  |         |            |
  |         +            +-> you issue id.
  |         |
  |         +-> Summary in present tense.
  |
  +-------> Type: feat, fix, docs, workflow, style, refactor, test, website, chore

Valid types:

  • feat: new feature for stonedb
  • fix: bug fix for stonedb
  • docs: changes to the documentation
  • workflow: ci/cd in .github
  • refactor: refactoring production code, eg. renaming a variable
  • style: formatting, missing semi colons, etc; no production code change
  • test: adding missing tests, refactoring tests; no production code change
  • website
  • chore: updating grunt tasks etc; no production code change

@mergify
Copy link
Contributor

mergify bot commented Nov 2, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@hustjieke
Copy link
Collaborator

This pull request's title should follow requirements next. @DandreChen please check it 👇.

Valid format:

fix(vc): fix sth..... (#3306)
  ^         ^---------^  ^----^
  |         |            |
  |         +            +-> you issue id.
  |         |
  |         +-> Summary in present tense.
  |
  +-------> Type: feat, fix, docs, workflow, style, refactor, test, website, chore

Valid types:

  • feat: new feature for stonedb
  • fix: bug fix for stonedb
  • docs: changes to the documentation
  • workflow: ci/cd in .github
  • refactor: refactoring production code, eg. renaming a variable
  • style: formatting, missing semi colons, etc; no production code change
  • test: adding missing tests, refactoring tests; no production code change
  • website
  • chore: updating grunt tasks etc; no production code change

@DandreChen pls fix the title.

@DandreChen DandreChen changed the title feature(tianmu): support alter table xxx modify xxx type NULL/NOT NULL(#860) feat(tianmu): support alter table xxx modify xxx type NULL/NOT NULL(#860) Nov 3, 2022
@mergify mergify bot added the PR-feature feature for pull request label Nov 3, 2022
@DandreChen DandreChen self-assigned this Nov 3, 2022
@DandreChen DandreChen added the C-stonedb-5.7 associated with stonedb 5.7 label Nov 3, 2022
@DandreChen
feat(tianmu): support alter table xxx modify xxx type NULL/NOT NULL(s…
37a1b92 
…toneatom#860)

support field properties from NULL to NOT NULL
support field properties from NOT NULL to NULL
@DandreChen DandreChen force-pushed the stonedb-5.7-dev branch 2 times, most recently from 27745d9 to b954b56 Compare November 4, 2022 03:57
@DandreChen DandreChen marked this pull request as draft November 4, 2022 03:57
@DandreChen DandreChen marked this pull request as ready for review November 4, 2022 04:58
hustjieke
hustjieke approved these changes Nov 4, 2022
View reviewed changes
Copy link
Collaborator

@hustjieke hustjieke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit d0c2e01 into stoneatom:stonedb-5.7-dev Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lujiashun lujiashun lujiashun left review comments

@hustjieke hustjieke hustjieke approved these changes

@RingsC RingsC RingsC approved these changes

@isredstar isredstar Awaiting requested review from isredstar

Assignees

@DandreChen DandreChen

Labels
C-stonedb-5.7 associated with stonedb 5.7 PR-feature feature for pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature(tianmu): support alter table xxx modify xxx type(length) default null
4 participants
@DandreChen @hustjieke @RingsC @lujiashun