Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tianmu): fix invalid write/read issue. (#817) #902

Merged
merged 2 commits into from
Nov 10, 2022
Merged

feat(tianmu): fix invalid write/read issue. (#817) #902

merged 2 commits into from
Nov 10, 2022

Conversation

lujiashun
Copy link

@lujiashun lujiashun commented Nov 8, 2022 •
edited
Loading

Summary about this PR

Issue Number: ref #817

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Improvement
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@lujiashun lujiashun self-assigned this Nov 8, 2022
@mergify
Copy link
Contributor

mergify bot commented Nov 8, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-feature feature for pull request label Nov 8, 2022
RingsC
RingsC suggested changes Nov 9, 2022
View reviewed changes
storage/tianmu/system/cacheable_item.cpp Outdated Show resolved Hide resolved
storage/tianmu/core/engine_results.cpp Show resolved Hide resolved
@lujiashun lujiashun marked this pull request as draft November 9, 2022 06:55
@lujiashun lujiashun force-pushed the feat-817 branch 2 times, most recently from 0baae76 to ce92a35 Compare November 9, 2022 07:30
@lujiashun lujiashun requested a review from RingsC November 9, 2022 08:30
@lujiashun lujiashun marked this pull request as ready for review November 9, 2022 08:31
RingsC
RingsC approved these changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@RingsC RingsC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hustjieke
hustjieke suggested changes Nov 10, 2022
View reviewed changes
storage/tianmu/system/cacheable_item.cpp Outdated Show resolved Hide resolved
storage/tianmu/system/cacheable_item.cpp Outdated Show resolved Hide resolved
@hustjieke hustjieke mentioned this pull request Nov 10, 2022
Merged
15 tasks
@lujiashun lujiashun force-pushed the feat-817 branch 2 times, most recently from 99cbb35 to ee6b889 Compare November 10, 2022 08:31
@lujiashun lujiashun requested a review from hustjieke November 10, 2022 09:11
hustjieke
hustjieke approved these changes Nov 10, 2022
View reviewed changes
Copy link
Collaborator

@hustjieke hustjieke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 6669693 into stoneatom:stonedb-8.0-dev Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hustjieke hustjieke hustjieke approved these changes

@RingsC RingsC RingsC approved these changes

@duanfuxiang0 duanfuxiang0 Awaiting requested review from duanfuxiang0

@DandreChen DandreChen Awaiting requested review from DandreChen

Assignees

@lujiashun lujiashun

Labels
PR-feature feature for pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lujiashun @RingsC @hustjieke