Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tianmu): fix crashed when the subquery includes a SORT clause (#906) #930

Closed
wants to merge 3 commits into from
Closed

fix(tianmu): fix crashed when the subquery includes a SORT clause (#906) #930

wants to merge 3 commits into from

Conversation

adofsauron
Copy link
Collaborator

@adofsauron adofsauron commented Nov 14, 2022 •
edited
Loading

Summary about this PR

    fix(tianmu): fix crashed when the subquery includes a SORT clause (#906)
    the reason is The subquery generates a temp table, 
    but the count(*) column of the subquery is not a physical column, 
    so the interface is incompatible.
    so if the virtual column does not point to the physical column, 
    the check is not performed

Issue Number: close #906

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Improvement
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@adofsauron
feat(tianmu): The Tianmu engine supports user defined function (#538)
0d33b76 
Supports user-defined functions and is compatible with mysql scalar data.
This version does not support composite data types such as json.

The solution of generating derived tables without collections
for custom functions is currently quite radical,
and a more elegant solution will be completed in the next iteration.
@adofsauron
fix(tianmu): fix crashed when the subquery includes a SORT clause (#906
e2110b4 
)

    the reason is The subquery generates a temp table,
    but the count(*) column of the subquery is not a physical column,
    so the interface is incompatible.
    so if the virtual column does not point to the physical column,
    the check is not performed
@mergify
Copy link
Contributor

mergify bot commented Nov 14, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-bug bug for pull request label Nov 14, 2022
@adofsauron adofsauron closed this by deleting the head repository Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR-bug bug for pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug:The instance crashed because the subquery includes a SORT clause but it cannot be flattened.
1 participant
@adofsauron