Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicating Spells Resetting Previously Duplicated Spellnames on the Spell Lists #216

Closed
KeatenStJ opened this issue Aug 10, 2023 · 1 comment
Assignees
Labels

Comments

@KeatenStJ
Copy link

Spell editor version
Please provide the spell editor version you are using.
Newest version 2.2.0

Describe the bug
A clear and concise description of what the bug is.
When duplicating the spells. If i have duplicated a few, it resets the previously duplicated spells spell name on the lists of spells area, but it doesnt actually change the spellname of the spells. Just what shows where it shows all the spells. It only does it to previously duplicated spells. It is easily fixed by going over the spells that has had the change happen to and resaving.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...' Start duplicating spells and changing spell names
  2. Click on '....' rinse and repeat
  3. Scroll down to '....' will notice previously duplicated ones revert their display spell name, not their actual spell name
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.
I can easily show on stream if that helps, #Keaten . Sorry im sure my explanation doesnt do a great job

@KeatenStJ KeatenStJ added the bug label Aug 10, 2023
stoneharry added a commit that referenced this issue Jan 16, 2024
This occurred when saving a spell becausue it would update it in the UI but not in the in-memory data table. So when the entry was next refreshed, it would refresh with the wrong information.

This change refactors the behaviour into the appropiate class and handles the data and UI update properly.
@stoneharry stoneharry self-assigned this Jan 16, 2024
@stoneharry
Copy link
Owner

Fixed with v.2.2.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants