Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): aliases take only array-ish given #2033

Merged
merged 3 commits into from
Jan 27, 2022
Merged

feat(core): aliases take only array-ish given #2033

merged 3 commits into from
Jan 27, 2022

Conversation

P0lip
Copy link
Contributor

@P0lip P0lip commented Jan 21, 2022 •
edited
Loading

As requested by @mnaumanali94, aliases are arrays-only now.
This is in line with that @marbemac suggested back in the previous PR.

Checklist

  • Tests added / updated
  • Docs added / updated

Does this PR introduce a breaking change?

  • Yes
  • No

@P0lip P0lip added enhancement New feature or request breaking Pull requests that introduce a breaking change labels Jan 21, 2022
@P0lip P0lip self-assigned this Jan 21, 2022
@P0lip P0lip force-pushed the feat/core/arrayish-aliases branch from dd22a58 to 37d92e9 Compare January 21, 2022 21:53
@P0lip P0lip marked this pull request as ready for review January 21, 2022 21:56
@P0lip P0lip requested a review from mnaumanali94 January 21, 2022 21:56
marbemac
marbemac approved these changes Jan 22, 2022
View reviewed changes
Copy link
Contributor

@marbemac marbemac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice - and always have the option to introduce non-array syntax in the future if there's high demand / use case for it.

Just one nit re the docs, otherwise looks good

docs/guides/4-custom-rulesets.md Show resolved Hide resolved
mnaumanali94
mnaumanali94 approved these changes Jan 24, 2022
View reviewed changes
Copy link
Contributor

@mnaumanali94 mnaumanali94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful. Hopefully we can get given here too eventually.

@P0lip
Copy link
Contributor Author

P0lip commented Jan 27, 2022

Despite it being a de jure breaking change, de facto it is not such since the actual usage is almost non-existent.
However, it's a one-off exception. I'd really love to follow the semantic versioning very strictly as always used to do.

@P0lip P0lip merged commit 263dc20 into develop Jan 27, 2022
@P0lip P0lip deleted the feat/core/arrayish-aliases branch January 27, 2022 12:03
stoplight-bot pushed a commit that referenced this pull request Jan 28, 2022
@StoplightSupport
chore(release): 1.10.0 [skip ci]
2d00438 
# [@stoplight/spectral-core-v1.10.0](https://github.com/stoplightio/spectral/compare/@stoplight/spectral-core-v1.9.0...@stoplight/spectral-core-v1.10.0) (2022-01-28)

### Features

* **core:** aliases take only array-ish given ([#2033](#2033)) ([263dc20](263dc20))
@stoplight-bot
Copy link
Collaborator

🎉 This PR is included in version @stoplight/spectral-core-v1.10.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

stoplight-bot pushed a commit that referenced this pull request Jan 28, 2022
@StoplightSupport
chore(release): 1.4.0 [skip ci]
98d0384 
# [@stoplight/spectral-rulesets-v1.4.0](https://github.com/stoplightio/spectral/compare/@stoplight/spectral-rulesets-v1.3.2...@stoplight/spectral-rulesets-v1.4.0) (2022-01-28)

### Features

* **core:** aliases take only array-ish given ([#2033](#2033)) ([263dc20](263dc20))
@stoplight-bot
Copy link
Collaborator

🎉 This PR is included in version @stoplight/spectral-rulesets-v1.4.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@P0lip P0lip mentioned this pull request Mar 10, 2022
Merged
4 tasks
@billiegoose
Copy link
Contributor

billiegoose commented Mar 10, 2022 •
edited
Loading

Despite it being a de jure breaking change, de facto it is not such since the actual usage is almost non-existent.
However, it's a one-off exception. I'd really love to follow the semantic versioning very strictly as always used to do.

a month later this change made it to Studio and SHOCKINGLY it broke styleguides! (of course it did 🙃) @mnaumanali94 making breaking changes and violating semver is a terrible idea. @P0lip trust your gut next time.

@yspotts yspotts mentioned this pull request Nov 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marbemac marbemac marbemac approved these changes

@mnaumanali94 mnaumanali94 mnaumanali94 approved these changes

Assignees

@P0lip P0lip

Labels
breaking Pull requests that introduce a breaking change enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@P0lip @stoplight-bot @billiegoose @marbemac @mnaumanali94