fix(rulesets): always allow string examples in asyncapi schema #2625
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: David Müller <d4ve.mone@googlemail.com>
|
@jonaslagoni @smoya Will you be able to review this anytime soon? |
mnaumanali94
approved these changes
Sep 13, 2024
jonaslagoni
approved these changes
Oct 3, 2024
|
@mnaumanali94 feel free to merge 👍 |
|
@jonaslagoni Thank you! I'm working on trying to fix the pipeline. There's something with a memory leak in node/jest. I'll merge some of the PRs then. |
|
All good @mnaumanali94 ✌️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2624.
Checklist
Does this PR introduce a breaking change?