Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: remove search option #23

Merged
merged 1 commit into from
May 18, 2023
Merged

Conversation

alanshaw
Copy link
Member

This PR removes the internal search option in favour of a block filter option.

I also fixed all the types in index.js...was having a hard time with Link vs CID and decided to upgrade everything to use Link, seeing as this is going out as a breaking change anyway.

@alanshaw alanshaw requested a review from olizilla May 18, 2023 13:38
Copy link
Contributor

@olizilla olizilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good 👍

UnknownLink is too much abstraction / verbose for me

@alanshaw alanshaw merged commit 9ede86f into main May 18, 2023
@alanshaw alanshaw deleted the refactor/remove-search-option2 branch May 18, 2023 14:20
alanshaw pushed a commit that referenced this pull request May 18, 2023
🤖 I have created a release *beep* *boop*
---


##
[7.0.0](v6.0.2...v7.0.0)
(2023-05-18)


### ⚠ BREAKING CHANGES

* remove search option
([#23](#23))
* rename dagScope to carScope
([#21](#21))

### Features

* add ordering option to getPath
([#19](#19))
([ad25001](ad25001))
* support yamux muxer
([#11](#11))
([24ef997](24ef997))


### Bug Fixes

* rename dagScope to carScope
([#21](#21))
([497cc90](497cc90))


### refactor

* remove search option
([#23](#23))
([9ede86f](9ede86f))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants