chore: sync with w3up repo #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were defaulting to the production URL unless a `receiptsEndpoint` was given in the options, and then never providing one. Passing it along would probably be the better solution, but there are a lot of places to get that wrong as things stand right now. It's not clear to me where the receipt URL really should live--eg., whether it should properly be part of the connection config.
fforbeck
force-pushed
the
chore/sync-w3up
branch
from
8ffaacf to
38b02f7
Compare
In cloudflare workers the request fails with: `The 'mode' field on 'RequestInitializerDict' is not implemented.`. Detecting cloudflare environment as advised by cloudflare: https://developers.cloudflare.com/workers/runtime-apis/web-standards/#navigatoruseragent
alanshaw
requested changes
Jan 16, 2025
alanshaw
approved these changes
Jan 16, 2025
fforbeck
force-pushed
the
chore/sync-w3up
branch
from
e4f79b8 to
14e4f37
Compare
This was referenced Jan 16, 2025
alanshaw
pushed a commit
that referenced
this pull request
Jan 20, 2025
🤖 I have created a release *beep* *boop* --- ## [1.0.3](upload-client-v1.0.2...upload-client-v1.0.3) (2025-01-16) ### Other Changes * sync with w3up repo ([#119](#119)) ([d86e52c](d86e52c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
alanshaw
pushed a commit
that referenced
this pull request
Jan 20, 2025
🤖 I have created a release *beep* *boop* --- ## [1.1.3](client-v1.1.2...client-v1.1.3) (2025-01-16) ### Other Changes * sync with w3up repo ([#119](#119)) ([d86e52c](d86e52c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
mode: corswhen cloudflare workers runtime w3up#1605Resolves storacha/project-tracking#263