feat: initial work to integrate access/authorize #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) add a new `authorize` command that invokes the new `access/authorize` capability 2) add a new `can access claim` command that invokes the new `access/claim` capability and prints the delegations it receives note that this requires in-progress work from the feat/implement-access-authorize-in-agent branches of @web3-storage/access and @web3-storage/w3up-client and I've left local file references to those in package.json - you may need to update them to work on this locally
This reverts commit a0cef03.
1) print less stuff from accessClaim 2) get rid of the wait before the spinner in registerSpace - it returns so quickly that this breaks things
travis
changed the title
Gozala
previously requested changes
Mar 21, 2023
Co-authored-by: Irakli Gozalishvili <contact@gozala.io>
also integrate feedback from @Gozala
alanshaw
approved these changes
Mar 22, 2023
travis
dismissed
Gozala’s stale review
I think I've addressed everything in this review - happy to follow up if not!
olizilla
pushed a commit
that referenced
this pull request
Mar 23, 2023
🤖 I have created a release *beep* *boop* --- ## [2.0.0](v1.2.2...v2.0.0) (2023-03-23) ### ⚠ BREAKING CHANGES * upgrade to latest access & upload clients ([#64](#64)) * move `space register` email parameter to an `--email` option and add `--provider` option ([#60](#60)) * use new account model ([#53](#53)) ### Features * move `space register` email parameter to an `--email` option and add `--provider` option ([#60](#60)) ([c1ed0e5](c1ed0e5)) * show help text if no cmd ([#63](#63)) ([fd5f342](fd5f342)) * update README with new ToS ([#62](#62)) ([4ce61d7](4ce61d7)), closes [#54](#54) * upgrade to latest access & upload clients ([#64](#64)) ([b5851ca](b5851ca)) * use new account model ([#53](#53)) ([7f63286](7f63286)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
authorizecommand that invokes the newaccess/authorizecapabilitycan access claimcommand that invokes the newaccess/claimcapability