Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update sst to v2 #152

Closed
wants to merge 1 commit into from
Closed

fix: update sst to v2 #152

wants to merge 1 commit into from

Conversation

vasco-santos
Copy link
Contributor

@vasco-santos vasco-santos commented Mar 7, 2023 •
edited
Loading

Fixes CI issue from sst/sst#2587 by updating to new sst and update aws sdk deps to be compatible. See migration guide for details.

In addition:

TODO:

@seed-deploy seed-deploy bot temporarily deployed to pr152 March 7, 2023 13:36 Inactive
@vasco-santos vasco-santos changed the title fix: update sst fix: update sst to v2 Mar 7, 2023
@vasco-santos vasco-santos mentioned this pull request Mar 7, 2023
Merged
@vasco-santos vasco-santos marked this pull request as draft March 7, 2023 14:06
vasco-santos added a commit that referenced this pull request Mar 7, 2023
@vasco-santos
fix: temporary fix for access log format to allow http gateway deploy (…
cd1db3d 
…#153)

Temporary fix for CI issue from
sst/sst#2587 as suggested in
sst/sst#2587 (comment)

The fix simply tweaks the `accessLog` format to not include the
`cognitoIdentityId` like fix from sst
https://github.com/serverless-stack/sst/pull/2602/files

In the meantime, hopefully sst team provides a fix for v1, or we need to
work on landing our update
#152 . I started by trying
to update, but after spending over 2 hours debugging random CI SegFaults
and other deployment issues decided to punt on this for now. v2 is quite
recent and maybe we should stay in v1 some more time given these
SegFault errors are likely not related to our code...
@travis
Copy link
Member

travis commented Aug 22, 2023

@vasco-santos for when you're back - should we get this resolved and merged?

@travis travis mentioned this pull request Aug 22, 2023
Closed
@vasco-santos
Copy link
Contributor Author

@travis it would be cool to land this as soon as possible. But I will need to get progress on w3filecoin side of things first

@travis
Copy link
Member

travis commented Aug 29, 2023

ok cool - I'm down to help with updating it and getting it merged - no rush, but maybe worth chatting about later this week!

@vasco-santos vasco-santos mentioned this pull request Sep 15, 2023
Merged
1 task
@vasco-santos
Copy link
Contributor Author

Please remember to revert

#233 (review)

@vasco-santos vasco-santos mentioned this pull request Sep 20, 2023
Merged
@olizilla
Copy link
Contributor

We could break the problem up a little, and extract services like roundabout to their own repo, and migrate it to SST v2 while we are at it. related to this and #84

@vasco-santos
Copy link
Contributor Author

We could break the problem up a little, and extract services like roundabout to their own repo, and migrate it to SST v2 while we are at it. related to this and #84

I think we will need to sync as a team on this type one. Maybe a topic for next Eng team monthly?

We previously decided to put all the things here, and that is why Roundabout came here. For instance, I also have feeling more and more that the kinesis thing should be in its own repo. But would like us to be consistent and go with an approach, instead of keeping changing between "All in same repo" and "all in different repo".

@vasco-santos
Copy link
Contributor Author

replaced by #335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vasco-santos @travis @olizilla