-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create new w3console project #225
Comments
Big open question is: what framework do we use? Currently leaning toward vite + preact but open to other ideas. Advantages of vite + preact:
|
React is what we use @web3-storage/website and nft.storage/website today. React has compatability with React. In general, I think it's fair to claim that the addressable audience of devs-who-have-used-react is much bigger than that of devs-who-have-used-preact. So personally I would recommend using 'just react' and not 'preact', or at least would point out that there are no benefits to preact-over-react presented here yet. with that said, I don't strong object to preact. I'd just recommend getting something functional with just the more common tooling before attempting it with less common tooling.
If composability is a goal, and I think it's a good one, I think a good way of guaranteeing it is to develop it as a component, but demo it inside a component gallery like storybook. If you're demoing something in storybook, it's guaranteed that it's composable. If not, whether the thing is using next.js or vite, it may still be not composable. You can do storybook w/ vite. If you dev a |
Yep totally agree here - the idea here is that if we use Preact we'll essentially be targetting React and Preact developers at the same time since Preact provides a subset of React's functionality. That said I've never actually used Preact for anything serious, so I'm not 100% sure this is true - @olizilla @yusefnapora I don't remember if either of you has more experience with Preact, but curious about your take here.
Yea this is basically the plan - we'd like to build w3console out of the "Customizable UI" components in #208. I do think we'll still need a new repository to provide basic app structure and chrome for the thing we want to deploy to I do think it's worth investigating storybook as a dev/test harness for the Customizable and Headless components in w3ui, especially since its support for snapshot testing (https://storybook.js.org/docs/react/writing-tests/snapshot-testing) might be extremely useful for #150 |
I want storybook now i'm working on components. I set it up for ipfs-gui and it was worth the effort. I'm going to add it to the As Ben pointed out, vite support in storybook is a thing now which is great, and even better, they just landed pnpm support in the upcoming v7 release available under the |
Add storybook scaffolding so we can iterate on our components and all the states they can be in. <img width="1427" alt="Screenshot 2023-01-18 at 16 58 32" src="https://user-images.githubusercontent.com/58871/213245880-9b5c448a-47c2-46a3-85f7-8b12056289da.png"> Uses the beta release of storybook v7 as it has support for pnpm. Part of #225 - we need this to demonstrate out components in all their possible states so we can make them good. License: MIT Signed-off-by: Oli Evans <oli@protocol.ai> Co-authored-by: Travis Vachon <travis.vachon@gmail.com>
I think it makes the most sense to create this as an example project in w3ui based on the branch in #208 and then to move to its own repository once that branch lands
The text was updated successfully, but these errors were encountered: