Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add warnings about the public and permanent nature of w3up uploads #502

Merged
merged 4 commits into from
Apr 10, 2023

Conversation

travis
Copy link
Member

@travis travis commented Apr 6, 2023

we'll probably want to rework this in the future, but I think this probably looks good enough for now:

Screenshot 2023-04-07 at 1 47 15 PM

Screenshot 2023-04-07 at 1 47 29 PM

resolves #464

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 6, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 59daabb:

Sandbox Source
@w3ui/example-react-file-upload Configuration
@w3ui/example-react-sign-up-in Configuration
@w3ui/example-react-uploads-list Configuration
@w3ui/example-solid-file-upload Configuration
@w3ui/example-solid-sign-up-in Configuration
@w3ui/example-solid-uploads-list Configuration
@w3ui/example-vue-file-upload Configuration
@w3ui/example-vue-sign-up-in Configuration
@w3ui/example-vue-uploads-list Configuration

@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023

@dchoi27
Copy link
Contributor

dchoi27 commented Apr 7, 2023

thanks! wdyt about making the warnings right justified instead of left? could also consider putting the warnings outside the dotted line?

@travis
Copy link
Member Author

travis commented Apr 7, 2023

wdyt about making the warnings right justified instead of left?
works for me! will update

@travis
Copy link
Member Author

travis commented Apr 7, 2023

could also consider putting the warnings outside the dotted line?

I like this even more! I think in this case we should just keep it below the upload box in both cases:

Screenshot 2023-04-07 at 1 47 15 PM

Screenshot 2023-04-07 at 1 47 29 PM

PR updated with this change!

Copy link
Contributor

@gobengo gobengo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, and I'm glad we are making this super clear.

@travis travis merged commit 6cc58f8 into main Apr 10, 2023
@travis travis deleted the fix/w3console-upload-warnings branch April 10, 2023 16:28
travis pushed a commit that referenced this pull request May 9, 2023
🤖 I have created a release *beep* *boop*
---


##
[1.5.0](w3console-v1.4.1...w3console-v1.5.0)
(2023-05-09)


### Features

* add warnings about the public and permanent nature of w3up uploads
([#502](#502))
([6cc58f8](6cc58f8)),
closes [#464](#464)
* get w3console looking acceptable on mobile
([#500](#500))
([118cb22](118cb22))
* remove space creator from sidebar
([#509](#509))
([40bc621](40bc621))
* update to latest version of ucanto and
[@web3-storage](https://github.com/web3-storage) libraries
([#514](#514))
([e1ee301](e1ee301))
* upload progress
([#499](#499))
([6c9de97](6c9de97))
* w3console cleanup and updates to packages to support it
([#507](#507))
([78aee2a](78aee2a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Travis Vachon <travis.vachon@protocol.ai>
Peeja pushed a commit to storacha/upload-service that referenced this pull request Jan 29, 2025
🤖 I have created a release *beep* *boop*
---


##
[1.5.0](storacha/w3ui@w3console-v1.4.1...w3console-v1.5.0)
(2023-05-09)


### Features

* add warnings about the public and permanent nature of w3up uploads
([storacha#502](storacha/w3ui#502))
([ad0632c](storacha/w3ui@ad0632c)),
closes [storacha#464](storacha/w3ui#464)
* get w3console looking acceptable on mobile
([storacha#500](storacha/w3ui#500))
([3e512df](storacha/w3ui@3e512df))
* remove space creator from sidebar
([storacha#509](storacha/w3ui#509))
([d5f5536](storacha/w3ui@d5f5536))
* update to latest version of ucanto and
[@web3-storage](https://github.com/web3-storage) libraries
([storacha#514](storacha/w3ui#514))
([f70ca5f](storacha/w3ui@f70ca5f))
* upload progress
([storacha#499](storacha/w3ui#499))
([81ae196](storacha/w3ui@81ae196))
* w3console cleanup and updates to packages to support it
([storacha#507](storacha/w3ui#507))
([f6fdf8e](storacha/w3ui@f6fdf8e))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Travis Vachon <travis.vachon@protocol.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warnings about public and permanent data
3 participants