Skip to content

Commit

Permalink
v8-to-istanbul 9.1.0 allows w3up-client c8 ignore comment reasons
Browse files Browse the repository at this point in the history
  • Loading branch information
gobengo committed Mar 27, 2023
1 parent d60400c commit 064c3c5
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 10 deletions.
1 change: 1 addition & 0 deletions packages/w3up-client/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@
"@ipld/car": "^5.1.1",
"@ucanto/server": "^6.1.0",
"assert": "^2.0.0",
"c8": "^7.13.0",
"docusaurus-plugin-typedoc": "^0.18.0",
"hundreds": "^0.0.9",
"mocha": "^10.1.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/w3up-client/src/capability/access.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { claimAccess, authorizeWithSocket } from '@web3-storage/access/agent'
* Client for interacting with the `access/*` capabilities.
*/
export class AccessClient extends Base {
/* c8 ignore start */
/* c8 ignore start - testing websocket code is hard */
/**
* Authorize the current agent to use capabilities granted to the passed
* email account.
Expand Down
4 changes: 2 additions & 2 deletions packages/w3up-client/src/client.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export class Client extends Base {
}
}

/* c8 ignore start */
/* c8 ignore start - testing websockets is hard */
/**
* Authorize the current agent to use capabilities granted to the passed
* email account.
Expand Down Expand Up @@ -131,7 +131,7 @@ export class Client extends Base {
return new Space(did, meta)
}

/* c8 ignore start */
/* c8 ignore start - hard to test this without authorize tests which require websockets */
/**
* Register the _current_ space with the service.
*
Expand Down
12 changes: 5 additions & 7 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 064c3c5

Please sign in to comment.