Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rm /packages/access-ws #593

Closed
gobengo opened this issue Mar 21, 2023 · 1 comment
Closed

rm /packages/access-ws #593

gobengo opened this issue Mar 21, 2023 · 1 comment

Comments

@gobengo
Copy link
Contributor

gobengo commented Mar 21, 2023 •
edited
Loading

Motivation:

  • I think it's unused?
  • if we don't need it, let's remove it, if only to not have to keep it's wrangler et al deps aligned with other packages that are used (dealing with this now adding r2 usage to access-api)
@travis
Copy link
Member

travis commented Mar 21, 2023

+1 afaik it's not used - plz delete

@gobengo gobengo mentioned this issue Mar 22, 2023
Merged
gobengo added a commit that referenced this issue Mar 22, 2023
@gobengo
chore: remove access-ws and access-client package tests that rely on …
9c34bf7 
…it (#596)

Motivation:
* #593 
* by removing this, [my other
PR](#578) doesn't have to
worry about this package anymore (I had to when I encountered some
miniflare/wrangler/workers-types/etc type mismatches when adopting
R2Bucket type)

Notes
* this removes some tests in access-client that tested against this
access-ws running in miniflare. If we need those back, we can always
checkout the things we want back from these commits. Putting #awake here
so it shows up in repo search results
* My understanding is that the websocket used by access-client agent is
different than the access-ws package implemented
gobengo added a commit that referenced this issue Apr 11, 2023
@gobengo
chore: remove access-ws and access-client package tests that rely on …
4eec69d 
…it (#596)

Motivation:
* #593 
* by removing this, [my other
PR](#578) doesn't have to
worry about this package anymore (I had to when I encountered some
miniflare/wrangler/workers-types/etc type mismatches when adopting
R2Bucket type)

Notes
* this removes some tests in access-client that tested against this
access-ws running in miniflare. If we need those back, we can always
checkout the things we want back from these commits. Putting #awake here
so it shows up in repo search results
* My understanding is that the websocket used by access-client agent is
different than the access-ws package implemented
Peeja pushed a commit to storacha/upload-service that referenced this issue Jan 17, 2025
@github-actions
chore(main): release react 1.0.0 (storacha#593)
3df195d 
🤖 I have created a release *beep* *boop*
---


## 1.0.0 (2023-11-28)


### Features

* adds space-finder autocomplete combobox
([storacha#268](storacha/w3ui#268))
([3dcd647](storacha/w3ui@3dcd647))
* allow users to set page size in W3APIProvider
([storacha#308](storacha/w3ui#308))
([814a293](storacha/w3ui@814a293))
* club tropical w3 auth boxen
([storacha#350](storacha/w3ui#350))
([2266eb2](storacha/w3ui@2266eb2))
* Customizable UI components
([storacha#208](storacha/w3ui#208))
([0a776fe](storacha/w3ui@0a776fe))
* implement reverse paging
([storacha#381](storacha/w3ui#381))
([10f059a](storacha/w3ui@10f059a))
* Improve upload component flow
([storacha#285](storacha/w3ui#285))
([ba9a3bf](storacha/w3ui@ba9a3bf))
* simplify ([storacha#591](storacha/w3ui#591))
([d1dfdf0](storacha/w3ui@d1dfdf0))
* Storybook story improvements
([storacha#294](storacha/w3ui#294))
([e0de2cc](storacha/w3ui@e0de2cc))


### Bug Fixes

* fix w3console styling
([storacha#320](storacha/w3ui#320))
([74a298c](storacha/w3ui@74a298c))
* remove authenticator class when registed
([storacha#352](storacha/w3ui#352))
([3668f3b](storacha/w3ui@3668f3b))
* w3console polish
([storacha#284](storacha/w3ui#284))
([9a67365](storacha/w3ui@9a67365))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Alan Shaw <alan.shaw@protocol.ai>
Peeja pushed a commit to storacha/upload-service that referenced this issue Jan 29, 2025
@github-actions
chore(main): release react 1.0.0 (storacha#593)
eea7020 
🤖 I have created a release *beep* *boop*
---


## 1.0.0 (2023-11-28)


### Features

* adds space-finder autocomplete combobox
([storacha#268](storacha/w3ui#268))
([5894cdc](storacha/w3ui@5894cdc))
* allow users to set page size in W3APIProvider
([storacha#308](storacha/w3ui#308))
([22d917a](storacha/w3ui@22d917a))
* club tropical w3 auth boxen
([storacha#350](storacha/w3ui#350))
([92fa065](storacha/w3ui@92fa065))
* Customizable UI components
([storacha#208](storacha/w3ui#208))
([1107544](storacha/w3ui@1107544))
* implement reverse paging
([storacha#381](storacha/w3ui#381))
([0077b34](storacha/w3ui@0077b34))
* Improve upload component flow
([storacha#285](storacha/w3ui#285))
([4f5cf4f](storacha/w3ui@4f5cf4f))
* simplify ([storacha#591](storacha/w3ui#591))
([7309e1d](storacha/w3ui@7309e1d))
* Storybook story improvements
([storacha#294](storacha/w3ui#294))
([c031ff7](storacha/w3ui@c031ff7))


### Bug Fixes

* fix w3console styling
([storacha#320](storacha/w3ui#320))
([31cbe91](storacha/w3ui@31cbe91))
* remove authenticator class when registed
([storacha#352](storacha/w3ui#352))
([e115f9f](storacha/w3ui@e115f9f))
* w3console polish
([storacha#284](storacha/w3ui#284))
([654d507](storacha/w3ui@654d507))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Alan Shaw <alan.shaw@protocol.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@travis @alanshaw @gobengo