Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(upload-api): fix incompatibilities with w3infra #504

Merged
merged 11 commits into from
Mar 8, 2023
Merged

Conversation

Gozala
Copy link
Contributor

@Gozala Gozala commented Mar 8, 2023

This PR makes changes needed for storacha/w3infra#154 namely:

  1. Fixes type mappings in package.json, otherwise TS is confused in w3infra.
  2. Removes obsolete index.js file that lives in w3infra now.
  3. Exports types so they can be used from w3infra.
  4. Updates return type from undefined to null to match what w3infra implementation returns.

@Gozala Gozala requested a review from gobengo March 8, 2023 01:18
@Gozala Gozala temporarily deployed to dev March 8, 2023 03:00 — with GitHub Actions Inactive
@Gozala Gozala requested a review from alanshaw March 8, 2023 03:01
@Gozala Gozala temporarily deployed to dev March 8, 2023 03:32 — with GitHub Actions Inactive
@Gozala Gozala temporarily deployed to dev March 8, 2023 04:44 — with GitHub Actions Inactive
@Gozala Gozala temporarily deployed to dev March 8, 2023 05:04 — with GitHub Actions Inactive
@Gozala Gozala temporarily deployed to dev March 8, 2023 06:26 — with GitHub Actions Inactive
@Gozala Gozala changed the title fix(upload-api): type maps fix(upload-api): fix incompatibilities with w3infra Mar 8, 2023
@Gozala Gozala temporarily deployed to dev March 8, 2023 06:45 — with GitHub Actions Inactive
@Gozala Gozala merged commit d3dcf34 into main Mar 8, 2023
@Gozala Gozala deleted the fix/upload-type-map branch March 8, 2023 07:37
Gozala pushed a commit that referenced this pull request Mar 8, 2023
🤖 I have created a release *beep* *boop*
---


##
[1.0.2](upload-api-v1.0.1...upload-api-v1.0.2)
(2023-03-08)


### Bug Fixes

* **upload-api:** fix incompatibilities with w3infra
([#504](#504))
([d3dcf34](d3dcf34))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Gozala added a commit to storacha/w3infra that referenced this pull request Mar 8, 2023
This PR depends on storacha/w3up#504,
which will require release and update here. With local symlink it works
as expected.
gobengo pushed a commit that referenced this pull request Apr 11, 2023
This PR makes changes needed for
storacha/w3infra#154 namely:

1. Fixes type mappings in `package.json`, otherwise TS is confused in
w3infra.
2. Removes obsolete `index.js` file that lives in w3infra now.
3. Exports types so they can be used from w3infra.
4. Updates return type from `undefined` to `null` to match what w3infra
implementation returns.
gobengo pushed a commit that referenced this pull request Apr 11, 2023
🤖 I have created a release *beep* *boop*
---


##
[1.0.2](upload-api-v1.0.1...upload-api-v1.0.2)
(2023-03-08)


### Bug Fixes

* **upload-api:** fix incompatibilities with w3infra
([#504](#504))
([bbd8703](bbd8703))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Peeja pushed a commit to storacha/upload-service that referenced this pull request Jan 17, 2025
🤖 I have created a release *beep* *boop*
---


##
[4.2.0](storacha/w3ui@vue-keyring-v4.1.1...vue-keyring-v4.2.0)
(2023-05-09)


### Features

* update to latest version of ucanto and
[@web3-storage](https://github.com/web3-storage) libraries
([storacha#514](storacha/w3ui#514))
([e1ee301](storacha/w3ui@e1ee301))
* upload progress
([storacha#499](storacha/w3ui#499))
([6c9de97](storacha/w3ui@6c9de97))
* w3console cleanup and updates to packages to support it
([storacha#507](storacha/w3ui#507))
([78aee2a](storacha/w3ui@78aee2a))


### Bug Fixes

* update @web3-storage/access dep to fix email + issue
([storacha#503](storacha/w3ui#503))
([d3b0bba](storacha/w3ui@d3b0bba))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Travis Vachon <travis.vachon@protocol.ai>
Peeja pushed a commit to storacha/upload-service that referenced this pull request Jan 29, 2025
🤖 I have created a release *beep* *boop*
---


##
[4.2.0](storacha/w3ui@vue-keyring-v4.1.1...vue-keyring-v4.2.0)
(2023-05-09)


### Features

* update to latest version of ucanto and
[@web3-storage](https://github.com/web3-storage) libraries
([storacha#514](storacha/w3ui#514))
([f70ca5f](storacha/w3ui@f70ca5f))
* upload progress
([storacha#499](storacha/w3ui#499))
([81ae196](storacha/w3ui@81ae196))
* w3console cleanup and updates to packages to support it
([storacha#507](storacha/w3ui#507))
([f6fdf8e](storacha/w3ui@f6fdf8e))


### Bug Fixes

* update @web3-storage/access dep to fix email + issue
([storacha#503](storacha/w3ui#503))
([19b2c0a](storacha/w3ui@19b2c0a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Travis Vachon <travis.vachon@protocol.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants