chore: rename ACCESS_API_R2 binding to DELEGATIONS, and configure wranger.toml to use env-specific buckets #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ml to use env-specific buckets
gobengo
changed the title
4 tasks
gobengo
added a commit
that referenced
this pull request
Apr 11, 2023
…nger.toml to use env-specific buckets (#603) Motivation: * #578 (comment) * #578 (comment)
Peeja
pushed a commit
to storacha/upload-service
that referenced
this pull request
Jan 17, 2025
I was hoping to keep these changes separate, but ran into some issues with using the new packages in examples that necessitated some build changes. 1) I've updated the `file-upload` example to use the new packages. I ran into a weird build issue trying to do this - something about `Authenticator` not being exported from the UMD builds? - and did some research into how other projects I like are built, which lead me to believe that `bunchee`, the tool SWR uses for builds (https://github.com/vercel/swr/blob/main/package.json#L94), is probably our best bet... 2) I love `bunchee` so far - it's much simpler and seems to do "the right things" when building TS into libraries suitable for use in a variety of modern JS environments. You can read more about bunchee here: https://github.com/huozhi/bunchee I've used `bunchee` to pull the build step into each of the packages separately, which should make it easier and more efficient to work on a single package in isolation. Because `bunchee` doesn't need a bunch of manual config, this was possible with a minimum of boilerplate and setup. 3) I've removed the old packages and a bunch of configs and docs that point to them. This made (2) easier, since I could just make a wholesale switch rather than trying to keep some stuff working with the old rollup builds and other stuff working with `bunchee`.
Peeja
pushed a commit
to storacha/upload-service
that referenced
this pull request
Jan 17, 2025
🤖 I have created a release *beep* *boop* --- ## [2.0.0](storacha/w3ui@core-v1.1.1...core-v2.0.0) (2023-12-11) ### ⚠ BREAKING CHANGES * fix example, buncheefication, cleanup ([storacha#603](storacha/w3ui#603)) ### Features * fix example, buncheefication, cleanup ([storacha#603](storacha/w3ui#603)) ([4a1c660](storacha/w3ui@4a1c660)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Peeja
pushed a commit
to storacha/upload-service
that referenced
this pull request
Jan 17, 2025
🤖 I have created a release *beep* *boop* --- ## [2.0.0](storacha/w3ui@react-v1.3.0...react-v2.0.0) (2023-12-11) ### ⚠ BREAKING CHANGES * fix example, buncheefication, cleanup ([storacha#603](storacha/w3ui#603)) ### Features * fix example, buncheefication, cleanup ([storacha#603](storacha/w3ui#603)) ([4a1c660](storacha/w3ui@4a1c660)) ### Bug Fixes * unpin core version ([storacha#611](storacha/w3ui#611)) ([69a8241](storacha/w3ui@69a8241)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Travis Vachon <travis.vachon@protocol.ai>
Peeja
pushed a commit
to storacha/upload-service
that referenced
this pull request
Jan 29, 2025
I was hoping to keep these changes separate, but ran into some issues with using the new packages in examples that necessitated some build changes. 1) I've updated the `file-upload` example to use the new packages. I ran into a weird build issue trying to do this - something about `Authenticator` not being exported from the UMD builds? - and did some research into how other projects I like are built, which lead me to believe that `bunchee`, the tool SWR uses for builds (https://github.com/vercel/swr/blob/main/package.json#L94), is probably our best bet... 2) I love `bunchee` so far - it's much simpler and seems to do "the right things" when building TS into libraries suitable for use in a variety of modern JS environments. You can read more about bunchee here: https://github.com/huozhi/bunchee I've used `bunchee` to pull the build step into each of the packages separately, which should make it easier and more efficient to work on a single package in isolation. Because `bunchee` doesn't need a bunch of manual config, this was possible with a minimum of boilerplate and setup. 3) I've removed the old packages and a bunch of configs and docs that point to them. This made (2) easier, since I could just make a wholesale switch rather than trying to keep some stuff working with the old rollup builds and other stuff working with `bunchee`.
Peeja
pushed a commit
to storacha/upload-service
that referenced
this pull request
Jan 29, 2025
🤖 I have created a release *beep* *boop* --- ## [2.0.0](storacha/w3ui@core-v1.1.1...core-v2.0.0) (2023-12-11) ### ⚠ BREAKING CHANGES * fix example, buncheefication, cleanup ([storacha#603](storacha/w3ui#603)) ### Features * fix example, buncheefication, cleanup ([storacha#603](storacha/w3ui#603)) ([b6e61f4](storacha/w3ui@b6e61f4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Peeja
pushed a commit
to storacha/upload-service
that referenced
this pull request
Jan 29, 2025
🤖 I have created a release *beep* *boop* --- ## [2.0.0](storacha/w3ui@react-v1.3.0...react-v2.0.0) (2023-12-11) ### ⚠ BREAKING CHANGES * fix example, buncheefication, cleanup ([storacha#603](storacha/w3ui#603)) ### Features * fix example, buncheefication, cleanup ([storacha#603](storacha/w3ui#603)) ([b6e61f4](storacha/w3ui@b6e61f4)) ### Bug Fixes * unpin core version ([storacha#611](storacha/w3ui#611)) ([63f49bd](storacha/w3ui@63f49bd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Travis Vachon <travis.vachon@protocol.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: