clang fixes #929
Merged
clang fixes #929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loop.c:151:23: error: unused variable 'sys_path' [-Werror,-Wunused-variable]
g_autofree gchar *sys_path = NULL;
crypto.c:749:40: error: redefinition of typedef 'BDCryptoKeyslotContext' is a C11 feature [-Werror,-Wtypedef-redefinition]
typedef struct _BDCryptoKeyslotContext BDCryptoKeyslotContext;
^
./crypto.h:234:40: note: previous definition is here
typedef struct _BDCryptoKeyslotContext BDCryptoKeyslotContext;
^
Turned out this was a private struct and these two static-const-array
cross-references were not really needed.
generic.c:185:52: error: initializer element is not a compile-time constant
.mkfs_options = fs_features[BD_FS_TECH_EXT2].mkfs,
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
generic.c:187:51: error: initializer element is not a compile-time constant
.resize_mode = fs_features[BD_FS_TECH_EXT2].resize,
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last commit deserves some testing.
Fixes #925