udiskslinuxblockobject: Try issuing BLKRRPART ioctl harder #1218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason even after acquiring a voluntary BSD lock on the device the BLKRRPART ioctl still fails with EBUSY. Wait a couple of msec and everything is fine. So try harder, several attempts, if busy. There might be number of things going on in the system and it's out of our control even when holding a lock.
|
Jenkins, test this please. |
|
Just for the record, we have seen this as well in the Cockpit tests: cockpit-project/cockpit#19574 Thanks for doing the retry on your level already! |
Later I realized it might have been some other UDisks thread that kept the device busy. We might perhaps need a global per-device lock... will see about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason even after acquiring a voluntary BSD lock on the device the BLKRRPART ioctl still fails with EBUSY. Wait a couple of msec and everything is fine.
So try harder, several attempts, if busy. There might be number of things going on in the system and it's out of our control even when holding a lock.
Fixes #1204