Cordova sqlite express EXPERIMENTAL WIP #730
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is some logcat output. The first few errors are expected in selfTest. The SQLITE_BUSY errors need more investigation. |
added 2 commits
December 11, 2017 20:05
needed for selfTest to pass on builtin android.database implementation (no Android-sqlite-connector / Android-sqlite-native-driver libraries) ref: storesafe#730
brodycj
force-pushed
the
cordova-sqlite-express-wip
branch
from
7269cba
to
d412eb5
Compare
brodycj
changed the title
|
This experimental WIP is now FIXED to pass selfTest on Android by fixing the SQLiteAndroidDatabase class to end transaction if active before closing. P.S. Another TODO item is to update some existing tests to pass on the builtin android.database implementation. |
|
An additional issue I noticed is that the builtin android.database implementation seems to treat numeric parameter values (integer or floating point) as string values. Needs further investigation. |
|
Another thing I noticed from the logcat output is that the builtin Android sqlite database implementation attempts to execute PRAGMA journal_mode to check the actual value when opening the database. This is what triggered the failure originally discussed here. But if I would check the result of PRAGMA journal_mode I do not get 100% same result on builtin android.database implementation vs Android-sqlite-connector, iOS, macOS ("osx"), Windows, or WP8. The following test case shows that PRAGMA journal_mode returns journal_mode value of "persist" on builtin android.database implementation, "delete" on the other implementations Android-sqlite-connector/iOS/macOS/Windows/WP8: it(suiteName + 'Check journal mode (plugin ONLY)', function(done) {
if (isWebSql) pending('SKIP: NOT SUPPORTED for (WebKit) Web SQL');
var db = openDatabase("Check-sqlite-PRAGMA-encoding.db", "1.0", "Demo", DEFAULT_SIZE);
expect(db).toBeDefined();
db.executeSql('PRAGMA journal_mode', [], function(rs) {
expect(rs).toBeDefined();
expect(rs.rows).toBeDefined();
expect(rs.rows.length).toBe(1);
expect(rs.rows.item(0).journal_mode).toBe('??');
// Close (plugin only) & finish:
(isWebSql) ? done() : db.close(done, done);
}, function(error) {
// NOT EXPECTED:
expect(false).toBe(true);
expect(error.message).toBe('--');
done();
});
}, MYTIMEOUT);P.S. TBD it is not certain whether which journal_mode value of DELETE or PERSIST would be more optimal on mobile platforms, especially Android & iOS. Performance comparison should be measured using something such as https://github.com/brodybits/Cordova-sqlite-perftest. |
brodycj
pushed a commit
to brodycj/cordova-sqlite-legacy
that referenced
this pull request
Dec 14, 2017
Needed for new BUG 666 workaround solution to pass selfTest in case of builtin android.database implementation (no Android-sqlite-connector / Android-sqlite-native-driver libraries). Ref: - storesafe/cordova-sqlite-storage#730 - storesafe/cordova-sqlite-storage#666
brodycj
pushed a commit
to brodycj/cordova-sqlite-legacy
that referenced
this pull request
Dec 14, 2017
Close db before opening (ignore close error) Now tested on builtin android.database implementation (no Android-sqlite-connector / Android-sqlite-native-driver libs). Ref: - storesafe/cordova-sqlite-storage#666 - storesafe/cordova-sqlite-storage#730
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOW FIXED (see comment below):
This experimental WIP change shows that the new BUG #666 workaround solution causes selfTest to fail on built-in android.database implementation (Android-sqlite-connector not used).This is a blocking issue for #687: new major release using built-in sqlite libraries on Android/iOS/macOSA FUTURE TODO item is to cover this scenario in an open/close/delete test.