Add ID Site support #19
Conversation
this fixes the scenario when the web app blows up if STORMPATH_APPLICAITON is a href.
- Added a setting STORMPATH_ENABLE_ID_SITE which basically switches the built in manual views/forms for the ID site ones. Another settings called STORMPATH_ID_SITE_CALLBACK_URL was added as well. - Updated the stormpath sdk dependency to point to the latest version. I was hitting the search issue with '/' and '&' charaters resulting in a bad error message informing me of invalid API credentials, and this has been resolved in the latest sdk version. - Added quickstart docs for this feature
|
Hey Deni, would you mind pulling in the latest develop changes and fixing the conflicts? I think there were some issues because the other PR fixed some of the same stuff as this, so there was some conflicts there. |
|
@rdegges updated. |
|
ping @rdegges |
|
@avojnovicDk heyo! Comments to follow =) |
| @@ -274,9 +319,13 @@ def application(self): | |||
| ctx = stack.top | |||
| if ctx is not None: | |||
| if not hasattr(ctx, 'stormpath_application'): | |||
| ctx.stormpath_application = self.client.applications.search( | |||
There was a problem hiding this comment.
We should prolly leave this original client behavior alone. This is going to need to be refactored in a different way in the near future.
|
We're also going to need to get some docstrings added to all helper functions / methods that are included in this library. In the Flask stuff the code is all pretty standardized style wise. Also: some style things need to change, primarily:
blah(
val=1,
val=2,
)You'll need to add spaces around the operator, eg: blah(
val = 1,
val = 2,
)This is just to keep stuff consistent. |
|
We also are missing some tests for this feature which will need to be added in, but those can be created pretty quickly I think. Just to assert the settings are being added properly, etc. |
|
@rdegges ^^ |
|
Quick ping -- wanna add some tests for this? Would be happy to merge it in =) |
No description provided.