-
Notifications
You must be signed in to change notification settings - Fork 36
feat: support for react-docgen-typescript-loader #61
feat: support for react-docgen-typescript-loader #61
Conversation
6ed259e
to
b5586cb
Compare
ba51493
to
d39b19c
Compare
d39b19c
to
6e0b30e
Compare
@ndelangen hi! could you please take a look at these PRs? (#61 & #60) |
6ae4a99
to
8d1dd16
Compare
@nekitk This package has gone a bit neglected, I'm sorry. Would you be interested in helping maintain this? I've invited you to the github org, this should give you the ability to merge these. |
Deployment failed with the following error:
|
@ndelangen sure, thanks! |
967f1e9
to
3831dee
Compare
Deployment failed with the following error:
|
@ndelangen Hi! I've merged some of the opened pull requests. Could you please publish a new version? Note that there were a breaking change in #65 — decorator usage changed from |
@nekitk what's you npm account url? |
So release a new major version? |
yes, as it has broken backward compatibility |
@nekitk enable 2FA for your npm account and you should be able to publish to https://www.npmjs.com/package/storybook-addon-smart-knobs 👍 |
@ndelangen released a new version 6.0.0, thanks! |
Hi @nekitk, for clarification if I've My main.js: module.exports = {
stories: ["../src/**/*.stories.(tsx|mdx)"],
webpackFinal: async (config) => {
config.module.rules.push({
test: /\.(ts|tsx)$/,
use: [
{
loader: require.resolve("babel-loader"),
options: {
presets: [["react-app", { flow: false, typescript: true }]],
},
},
{
loader: require.resolve("react-docgen-typescript-loader"),
options: {
tsconfigPath: path.resolve(__dirname, "../tsconfig.json"),
},
},
],
});
config.resolve.extensions.push(".ts", ".tsx");
return config;
},
addons: [
"@storybook/addon-a11y",
"@storybook/addon-essentials",
"@storybook/addon-actions",
"@storybook/addon-knobs",
"@storybook/addon-docs",
"@storybook/addon-links",
],
}; And would preloading globally in import { addDecorator } from '@storybook/react';
import { withKnobs } from "@storybook/addon-knobs";
import { withSmartKnobs } from 'storybook-addon-smart-knobs'
/**
* May need additional config
* https://github.com/storybookjs/addon-smart-knobs#configuration
*/
addDecorator(withSmartKnobs())
addDecorator(withKnobs); |
Hi! No, you don't need to configure Preloading globally should work. |
Thank you! I appreciate your work on this. |
Fixes #25