Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SB7 #191

Closed
yarinsa opened this issue Apr 2, 2023 · 8 comments
Closed

Support SB7 #191

yarinsa opened this issue Apr 2, 2023 · 8 comments
Labels
category: feature New feature or request

Comments

@yarinsa
Copy link

yarinsa commented Apr 2, 2023

Is your feature request related to a problem? Please describe.
Yes. We are starting a new design system based on SB7, which will be stable in the next few weeks. When can we expect support?

Describe the solution you'd like
Upgrade to the new adding api

Describe alternatives you've considered
None.

@yarinsa yarinsa added the category: feature New feature or request label Apr 2, 2023
@byjokese
Copy link

byjokese commented Apr 3, 2023

Same Here, testing the pre-release version of the final v7.0.0, and many add-ons broke as the plugin API changed.

Interested in the new update for addon-designs.

@Codex-
Copy link

Codex- commented Apr 3, 2023

We've been using https://github.com/storybookjs/addon-designs/releases/tag/v7.0.0-beta.2 successfully, would be great to see a stable release though :)

Worth reading this comment: #178 (comment)
As referenced here: storybookjs/storybook#20529

@byjokese
Copy link

byjokese commented Apr 4, 2023

Yep, did not see the beta, with the beta.2 works perfectly.

@Codex-
Copy link

Codex- commented Apr 4, 2023

If you encounter this:

▲ [WARNING] Calling "copy" will crash at run-time because it's an import namespace object, not a function [call-import-namespace]

    node_modules/@figspec/components/esm/es2015/FigspecViewer/InspectorView/InspectorView.js:62:42:
      62 │               ${CopyIcon({ onClick: () => copy(node.characters) })}
         ╵                                           ~~~~

  Consider changing "copy" to a default import instead:

    node_modules/@figspec/components/esm/es2015/FigspecViewer/InspectorView/InspectorView.js:2:7:
      2 │ import * as copy from "copy-to-clipboard";
        │        ~~~~~~~~~
        ╵        copy

Then remove storybook-addon-designs (and anything else showing as an importer via npm ls @figspec/components), perform an npm i, then add it back, and npm i again. This should bump the lock version, which resolves the error upstream. Or add @figspec/components as a dep@latest then remove it again :)

@mayerraphael
Copy link

Does not work with 7.0.7. getChannel() is not defined error.

@immanual-tsw
Copy link

Hi,
I am getting this warning while installing storybook-addon-designs.

"Attention: We've detected that you're using the following addons in versions which are known to be incompatible with Storybook 7:

  • storybook-addon-designs@6.3.1
    Please be aware they might not work in Storybook 7. Reach out to their maintainers for updates

@pocka
Copy link
Collaborator

pocka commented Jun 10, 2023

WIP #192

@thafryer
Copy link
Collaborator

thafryer commented Jul 7, 2023

Hi Everyone! We have released a new version of the addon. We also changed the package name for the addon, @storybook/addon-designs. Please follow instructions from the readme to get going with the latest version.

https://github.com/storybookjs/addon-designs/blob/master/README.md

@thafryer thafryer closed this as completed Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: feature New feature or request
Projects
None yet
Development

No branches or pull requests

7 participants