-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency on @storybook/api or incompatibility with latest alpha of storybook #178
Comments
Oh... that's an uncomfortable breaking change... I believe there is no way to avoid manually installing
I'll update README once Storybook v7.0-beta is shipped. |
Maybe you might escalate that to sb team. It's still an alpha so maybe it wasn't intended an/or can be reconsidered? |
@jrencz It seems the |
@pocka Sorry for the delay - I had some rough time on the project before holidays and I didn't have time to upgrade SB until today. I tried on 7.0.0-beta.15 and the original problem is gone.
This one does exist on NPM: https://www.npmjs.com/package/@storybook/addons/v/7.0.0-beta.15 yet it's not being isntalled out of the box with There's a warning in readme:
Both |
I'm one of the Storybook maintainers. I focus primarily on documentation and community outreach. Just wanted to follow up on this issue, letting you know that the Storybook API for building addons is currently being updated to factor in the changes introduced by the upcoming 7.0 release. If you're interested in making the required changes to help the community from benefiting from using your addon, we've prepared an abridged guide for the required changes here, and if you have any questions or issues, please reach out to us in the #prerelease channel in our Discord Server. Hope you have a great day! Stay safe |
I failed to reproduce the
@jrencz @jonniebigodes |
By the end of the week I will check what I have now (last time I updated it was beta.19) and confirm if that problem still exists. And if it does I'll try bumping to beta.25 |
At the time I wrote #178 (comment) and so far in my setup it looks like that:
and it worked. Now I removed explicit dependency on Then I removed and added back I suppose it now works purely be accident - because I use I hope to have some more time to try beta.25 later - maybe something that comes with it (or with |
@pocka thanks for following up with me on this. Appreciate it 🙏 ! Glad that everything is already being already working with the new API, should any issue arise, don't hesitate to reach out to us via our Discord Server or the issue tracker. Hope you have a great day. Stay safe |
As a followup to my previous comment #178 (comment) I now tried updating storybook from It satisfies
would be back. To my knowledge |
I was getting the same error
I resolved it with npm i -D @storybook/addons (I spun up a Stackblitz with the I'm on Storybook (and
|
@olets Thanks for your input. It might not be clear: I don't have any problem if I have I'm pointing out that I have any version purely because I have some other addons, msw addon in my case. In case I didn't use that one then error would appear and I would have done what you suggested: install Designs addon does depend on API from package |
No. While using In an ideal world, package managers should pick/resolve the correct versions of Storybook libs even they are listed as direct dependencies. Unfortunately package managers most of the times failed to resolve to a version user installed. This is why it's
I believe Stackblitz being strict instead of picky. Installing them locally is the reliable solution and a workaround for now. |
@pocka thanks for the link. I studied that repo and now I know a little more It's even mentioned explicitly in https://storybook.js.org/docs/react/addons/writing-addons#packaging-and-publishing (and same in docs for upcoming 7.0) but the It was set to My assessment is that the guideline might not yet have been revised for the dependency structure of |
Hi Everyone! We have released a new version of the addon. We also changed the package name for the addon, @storybook/addon-designs. Please follow instructions from the readme to get going with the latest version. https://github.com/storybookjs/addon-designs/blob/master/README.md |
Affected design types
Describe the bug
I updated Storybook from
alpha.49
toalpha.54
(next
as of today) andstorybook-addon-designs
frombeta.1
tobeta.2
and I got the following error:Installing
@storybook/api
in project as project's own devDependency resolves the problemHow to reproduce the bug?
7.0.0-alpha.49
and storybook-addon-designs7.0.0-beta.1
, check that storybook starts without errorsalpha.54
andstorybook-addon-designs
tobeta-2
, check that there are errors during start of storybook (storybook dev
)Expected behaviour
There's no need to install
@storybook/api
in project to makestorybook-addon-designs
not breakstorybook dev
After quick bisect it turned out that
alpha.54
stopped installing@storybook/api
as its dependencyhttps://github.com/storybookjs/storybook/blob/next/CHANGELOG.md#700-alpha54-november-25-2022
Environment
Affected versions
7.0.0-beta.2
Storybook versions
7.0.0-alpha.54
The text was updated successfully, but these errors were encountered: