Migrate to npm, upgrade dependencies #59
Conversation
|
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is new author?A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package. Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights. What is eval?Package uses eval() which is a dangerous function. This prevents the code from running in certain environments and increases the risk that the code may contain exploits or malicious behavior. Avoid packages that use eval, since this could potentially execute any code. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
Co-authored-by: Jeppe Reinhold <jeppe@reinhold.is>
…nto upgrade-packages
…nto peer-dependency-bundling
| "@storybook/blocks": "7.0.0", | ||
| "@storybook/components": "7.0.0", | ||
| "@storybook/core-events": "7.0.0", | ||
| "@storybook/manager": "0.0.0-pr-24676-sha-214a6f84", |
There was a problem hiding this comment.
The version of this caught my eye. What are these new packages up to?
There was a problem hiding this comment.
They are used in the tsup config, they now export a globalPackages list that the config use to mark the packages as externals.
https://github.com/storybookjs/addon-kit/pull/59/files#diff-fef3a6dda67c2301a9bd345eb8d60c3ffee2433242c7f45d55a03f2e7908be21R6-R7
None of these packages will make it into the final addon dist, they are of no use to the addon, which is why I think it's safe for them to be a completely different version.
Ideally we'll change this version to ^7.6.0 when that gets released
There was a problem hiding this comment.
In that case, merge away, my friend :D
This PR does two things:
Migrate from Yarn v1 to npm to make it easier for new addon authors to adopt. Yarn v1 is EOL, and any addon author that prefers Yarn/pnpm knows how to migrate to those, but the opposite is not always true.
Upgrade all dependencies (except for
@types/node). It fixed a couple of audits.You could argue that we should stick Storybook to v7.0.0 to encourage addon authors to support the full range of 7.0-7.99 and test against the lowest possible number, instead of only testing against 7.5+. However if we think that's best, we should pin the dependencies completely and not use the caret range which we're doing currently anyway.Pin Storybook dependencies to 7.0.0 (without the caret) to encourage authors to test against the lowest version when building addons.
Change React dependencies to v16, as that is what will eventually be used in the SB manager UI regardless of what an addon specifies.