Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type errors due to imports from @storybook/types #198

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Fix type errors due to imports from @storybook/types #198

merged 2 commits into from
Aug 6, 2024

Conversation

rChaoz
Copy link
Contributor

@rChaoz rChaoz commented Aug 5, 2024

Closes #194

JReinhold
JReinhold requested changes Aug 5, 2024
View reviewed changes
Copy link
Collaborator

@JReinhold JReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't be compatible with Storybook versions below 8.2.

I think this should be done instead.

#194 (comment)

@rChaoz
Copy link
Contributor Author

rChaoz commented Aug 5, 2024

@JReinhold like this?

@rChaoz rChaoz changed the title Replace references to @storybook/types Fix type errors due to imports from @storybook/types Aug 5, 2024
JReinhold
JReinhold requested changes Aug 5, 2024
View reviewed changes
Copy link
Collaborator

@JReinhold JReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 Thanks

package.json Outdated Show resolved Hide resolved
@JReinhold JReinhold added patch Increment the patch version when merged dependencies Update one or more dependencies version labels Aug 5, 2024
@JReinhold JReinhold merged commit b2f157c into storybookjs:main Aug 6, 2024
@shilman
Copy link
Member

shilman commented Aug 6, 2024

🚀 PR was released in v4.1.5 🚀

@shilman shilman added the released This issue/pull request has been released. label Aug 6, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JReinhold JReinhold JReinhold approved these changes

Assignees
No one assigned
Labels
dependencies Update one or more dependencies version patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Broken types - @storybook/types issue
3 participants
@rChaoz @shilman @JReinhold