v5: Fix tags being ignored

[JReinhold]

Fixes #200

We can't and shouldn't "precombine" tags in the indexer, we should just pass them in, making sure they are in the right order. Storybook will internally combine the tags correctly, with the project-level tags.

Consider the following example:

• project-level: ['dev', 'test'] (this is the default)
• meta-level: ['!dev', '!test', '!autodocs'] (disable everything)
• story-level: ['test', 'autodocs'] (enable tests and docs for this specific story, still keeping sidebar disabled)

If the indexer combines the meta and story tags with combineTags(), they'll end up as ['test', 'autodocs'] ('!dev' will be omitted completely, because it's not enabled). Then this gets passed to Storybook, which combines them with project-level tags, resulting in ['dev', 'test', 'autodocs']. This is wrong, 'dev' should not be there as it was disabled at the meta-level, but Storybook doesn't know that because the indexer already omitted '!dev'.

If we instead don't combine anything and let Storybook do it with the project level tags, it will get the following series:

['dev', 'test', '!dev', '!test', '!autodocs', 'test', 'autodocs']. Parsing these sequentially will yield the correct result: ['test', 'autodocs']

📦 Published PR as canary version: 4.1.7--canary.206.e4feeae.0

✨ Test out this PR locally via:

npm install @storybook/addon-svelte-csf@4.1.7--canary.206.e4feeae.0
# or 
yarn add @storybook/addon-svelte-csf@4.1.7--canary.206.e4feeae.0

Version

Published prerelease version: v5.0.0-next.3

Changelog

💥 Breaking Change

• Fix missing @storybook/docs-tools dependency #190 (@JReinhold)
• Experimental support for Svelte 5 #181 (@tsar-boomba @xeho91 @JReinhold @benoitf)

🐛 Bug Fix

• v5: Fix tags being ignored #206 (@JReinhold)
• fix(parser): Resolve autodocs tag issue and extracting rawCode #201 (@xeho91)
• chore: use dist folder to load the files #185 (@benoitf)

Authors: 4

• Florent BENOIT (@benoitf)
• Isaiah Gamble (@tsar-boomba)
• Jeppe Reinhold (@JReinhold)
• Mateusz Kadlubowski (@xeho91)

[xeho91]

Ahhh, I see. My misuse of combineTags was the culprit!
Thanks for explaining it so thoroughly 🙏

[shilman]

🚀 PR was released in v5.0.0-next.3 🚀