Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests not being found when testing lit-ts example on Windows CI #358

Merged
merged 1 commit into from
May 8, 2022
Merged

Fix tests not being found when testing lit-ts example on Windows CI #358

merged 1 commit into from
May 8, 2022

Conversation

joshwooding
Copy link
Member

No description provided.

@IanVS
Copy link
Member

IanVS commented Apr 27, 2022

Stories.json is needed for the .mdx story. storybookjs/test-runner#36

@joshwooding
Copy link
Member Author

There's a bug in Jest: jestjs/jest#8536

@joshwooding joshwooding changed the title Try standardising lit-ts example Fix tests not being found when testing lit-ts example on Windows CI May 8, 2022
@joshwooding joshwooding marked this pull request as ready for review May 8, 2022 14:03
@joshwooding joshwooding requested a review from IanVS May 8, 2022 14:28
@joshwooding joshwooding mentioned this pull request May 8, 2022
Merged
IanVS
IanVS approved these changes May 8, 2022
View reviewed changes
Copy link
Member

@IanVS IanVS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find/fix!

@joshwooding joshwooding merged commit c526544 into main May 8, 2022
@joshwooding joshwooding deleted the experiment branch May 8, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanVS IanVS IanVS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshwooding @IanVS