Move examples out of workspaces #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moving the examples out of the monorepo means we won't have a top-level project to build these all from anymore. Maybe we can find a way to add it back in later, though.
This allows each example to be its own project, and avoids mixing dependencies between all of them.
IanVS
force-pushed
the
remove-examples-from-workspaces
branch
3 times, most recently
from
1a31b59
to
3ac2a74
Compare
IanVS
force-pushed
the
remove-examples-from-workspaces
branch
from
3ac2a74
to
a86e59d
Compare
IanVS
force-pushed
the
remove-examples-from-workspaces
branch
from
fc112da
to
a8f9328
Compare
IanVS
force-pushed
the
remove-examples-from-workspaces
branch
from
b853115
to
6ecdd8c
Compare
IanVS
force-pushed
the
remove-examples-from-workspaces
branch
from
65707dd
to
f98a063
Compare
This was referenced Sep 24, 2022
Merged
joshwooding
approved these changes
Sep 27, 2022
IanVS
added a commit
that referenced
this pull request
Sep 28, 2022
This cherry-picks some commits from @heykc's PR #469, but puts them on top of #502, so that we can have multiple versions of vue examples that don't conflict with each other in the monorepo, which was one of the challenges in the original PR. This also attempts to read the version of `vue` from the user's package.json, determine whether it's 2.6 or 2.7, and use the appropriate vite plugin, as suggested by @Djaler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We sometimes have trouble with our examples because of hoisting issues. So, instead of using a monorepo, this PR would turn this repo into a multi-project repo, with no top-level package.json, and instead each example would be stand-alone, and so would
packages/builder-vite.I'm not positive this is the way to go, but it did already suss out a few issues with missing dependencies in both the projects as well as the builder-vite itself.
One thing that's a bit wonky is that since the builder-vite has a completely different node_modules, it can't use any of the packages that are installed in the example, like preact and the vite preact plugin in the preact example. I added them as dev deps to the builder, which works fine I think. It's a downside, but on the other hand it makes these deps a little bit explicit without bloating the dependencies for users.