Merge pull request #105 from storybookjs/fix/filter-local-addons

no-uninstalled-addons: improve local addons filter
storybookjs · Aug 8, 2022 · 9ba3329 · 9ba3329
2 parents 680f4be + 877f93f
commit 9ba3329
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/lib/rules/no-uninstalled-addons.ts b/lib/rules/no-uninstalled-addons.ts
@@ -84,14 +84,25 @@ export = createStorybookRule({
       return installedAddons.includes(addonName)
     }
 
+    const filterLocalAddons = (addon: string) => {
+      const isLocalAddon = (addon: string) =>
+        addon.startsWith('.') ||
+        addon.startsWith('/') ||
+        // for local Windows files e.g. (C: F: D:)
+        /\w:.*/.test(addon) ||
+        addon.startsWith('\\')
+
+      return !isLocalAddon(addon)
+    }
+
     type AreThereAddonsNotInstalled = (
       addons: string[],
       installedSbAddons: string[]
     ) => false | { name: string }[]
     const areThereAddonsNotInstalled: AreThereAddonsNotInstalled = (addons, installedSbAddons) => {
       const result = addons
         // remove local addons (e.g. ./my-addon/register.js)
-        .filter((addon) => !addon.startsWith('.'))
+        .filter(filterLocalAddons)
         .filter((addon) => !isAddonInstalled(addon, installedSbAddons))
         .map((addon) => ({ name: addon }))
       return result.length ? result : false

diff --git a/tests/lib/rules/no-uninstalled-addons.test.ts b/tests/lib/rules/no-uninstalled-addons.test.ts
@@ -93,6 +93,10 @@ ruleTester.run('no-uninstalled-addons', rule, {
           addons: [
             "../my-local-addon",
             "../my-local-addon/index.cjs",
+            "/Users/foo/my-local-addon/index.js",
+            "/mount/foo/my-local-addon/index.js",
+            "C:\\Users\\foo\\my-local-addon/index.js",
+            "D:\\Users\\foo\\my-local-addon/index.js",
           ]
         }
     `,